Extract confirmation check to before action

This commit is contained in:
Matt Jankowski 2025-07-20 12:19:56 -04:00
parent 9326490325
commit 0dfa014fba

View File

@ -8,6 +8,7 @@ module Admin
before_action :populate_domain_block_from_params
before_action :prevent_downgrade
before_action :attempt_transparent_upgrade, if: :existing_domain_block
before_action :verify_confirmation_needed
end
PERMITTED_PARAMS = %i(
@ -44,9 +45,6 @@ module Admin
end
def create
# Require explicit confirmation when suspending
return render :confirm_suspension if requires_confirmation?
if @domain_block.save
DomainBlockWorker.perform_async(@domain_block.id)
log_action :create, @domain_block
@ -108,6 +106,11 @@ module Admin
end
end
def verify_confirmation_needed
# Require explicit confirmation when suspending
render :confirm_suspension if requires_confirmation?
end
def existing_domain_block
@existing_domain_block ||= DomainBlock.rule_for(resource_params[:domain]) if resource_params[:domain].present?
end