Revoke quote posts when those get deleted (#35614)

2025-09-06 18:01:05 +00:00 · 2025-07-31 16:23:36 +02:00 · 2025-07-31 16:23:36 +02:00 · 0e249cba4b
commit 0e249cba4b
parent 19db4cb7c1
2 changed files with 5 additions and 0 deletions
--- a/app/services/activitypub/process_status_update_service.rb
+++ b/app/services/activitypub/process_status_update_service.rb
@ -298,6 +298,8 @@ class ActivityPub::ProcessStatusUpdateService < BaseService
      if @status.quote.present?
        # If the quoted post has changed, discard the old object and create a new one
        if @status.quote.quoted_status.present? && ActivityPub::TagManager.instance.uri_for(@status.quote.quoted_status) != quote_uri
+          # Revoke the quote while we get a chance… maybe this should be a `before_destroy` hook?
+          RevokeQuoteService.new.call(@status.quote) if @status.quote.quoted_account&.local? && @status.quote.accepted?
          @status.quote.destroy
          quote = Quote.create(status: @status, approval_uri: approval_uri, legacy: @status_parser.legacy_quote?)
          @quote_changed = true
--- a/app/services/remove_status_service.rb
+++ b/app/services/remove_status_service.rb
@ -47,6 +47,9 @@ class RemoveStatusService < BaseService
        remove_media
      end

+      # Revoke the quote while we get a chance… maybe this should be a `before_destroy` hook?
+      RevokeQuoteService.new.call(@status.quote) if @status.quote&.quoted_account&.local? && @status.quote&.accepted?
+
      @status.destroy! if permanently?
    end
  end