Extract existing_domain_block private method

This commit is contained in:
Matt Jankowski 2025-07-20 12:10:48 -04:00
parent 523e7ee2cd
commit 3b087708a7

View File

@ -41,7 +41,6 @@ module Admin
def create def create
@domain_block = DomainBlock.new(resource_params) @domain_block = DomainBlock.new(resource_params)
existing_domain_block = resource_params[:domain].present? ? DomainBlock.rule_for(resource_params[:domain]) : nil
# Disallow accidentally downgrading a domain block # Disallow accidentally downgrading a domain block
if existing_domain_block.present? && !@domain_block.stricter_than?(existing_domain_block) if existing_domain_block.present? && !@domain_block.stricter_than?(existing_domain_block)
@ -99,6 +98,10 @@ module Admin
authorize :domain_block, :create? authorize :domain_block, :create?
end end
def existing_domain_block
@existing_domain_block ||= DomainBlock.rule_for(resource_params[:domain]) if resource_params[:domain].present?
end
def set_domain_block def set_domain_block
@domain_block = DomainBlock.find(params[:id]) @domain_block = DomainBlock.find(params[:id])
end end