From 4042bc959bcfc9d894c1f9e7e008d1a87a349b88 Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Wed, 30 Jul 2025 06:38:04 -0400
Subject: [PATCH] Use `increment` for `User#update_sign_in!` optional change
 (#35573)

---
 app/models/user.rb | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/app/models/user.rb b/app/models/user.rb
index 06a28761190..669b51c0698 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -228,10 +228,7 @@ class User < ApplicationRecord
     self.last_sign_in_at     = old_current || new_current
     self.current_sign_in_at  = new_current
 
-    if new_sign_in
-      self.sign_in_count ||= 0
-      self.sign_in_count  += 1
-    end
+    increment(:sign_in_count) if new_sign_in
 
     save(validate: false) unless new_record?
     prepare_returning_user!