Fix Style/GuardClause in User#wrap_email_confirmation (#35524)

This commit is contained in:
Matt Jankowski 2025-07-28 04:52:59 -04:00 committed by GitHub
parent 86ef4d4884
commit 916cc1365e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -466,9 +466,11 @@ class User < ApplicationRecord
yield
if new_user
# Avoid extremely unlikely race condition when approving and confirming
# the user at the same time
after_confirmation_tasks if new_user
end
def after_confirmation_tasks
# Handle condition when approving and confirming a user at the same time
reload unless approved?
if approved?
@ -477,7 +479,6 @@ class User < ApplicationRecord
notify_staff_about_pending_account!
end
end
end
def sign_up_from_ip_requires_approval?
sign_up_ip.present? && IpBlock.severity_sign_up_requires_approval.containing(sign_up_ip.to_s).exists?