gnh1201/mastodon
1
0
Fork 0
mirror of https://github.com/mastodon/mastodon.git synced 2025-09-05 17:31:12 +00:00
Code Issues Actions 34 Packages Projects Releases Wiki Activity

Add coverage for "live TOS" and "no TOS" paths in tos/drafts spec (#35902)

Browse Source
This commit is contained in:
Matt Jankowski 2025-08-26 04:43:43 -04:00 committed by GitHub
parent 460043a969
commit a8166d28ed
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 65 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

89
spec/system/admin/terms_of_service/drafts_spec.rb
View File

@ -8,34 +8,75 @@ RSpec.describe 'Admin TermsOfService Drafts' do
before { sign_in(admin_user) } before { sign_in(admin_user) }
describe 'Managing TOS drafts' do describe 'Managing TOS drafts' do
let!(:terms) { Fabricate :terms_of_service, published_at: nil } context 'when a draft TOS record exists' do
let!(:terms) { Fabricate :terms_of_service, published_at: nil }
it 'saves and publishes TOS drafts' do it 'saves and publishes TOS drafts' do
visit admin_terms_of_service_draft_path visit admin_terms_of_service_draft_path
expect(page) expect(page)
.to have_title(I18n.t('admin.terms_of_service.title')) .to have_title(I18n.t('admin.terms_of_service.title'))
# Invalid submission # Invalid submission
expect { click_on I18n.t('admin.terms_of_service.save_draft') } expect { click_on I18n.t('admin.terms_of_service.save_draft') }
.to_not(change { terms.reload.published_at }) .to_not(change { terms.reload.published_at })
expect(page) expect(page)
.to have_title(I18n.t('admin.terms_of_service.title')) .to have_title(I18n.t('admin.terms_of_service.title'))
# Valid submission with draft button # Valid submission with draft button
fill_in 'terms_of_service_text', with: 'new' fill_in 'terms_of_service_text', with: 'new'
expect { click_on I18n.t('admin.terms_of_service.save_draft') } expect { click_on I18n.t('admin.terms_of_service.save_draft') }
.to not_change { terms.reload.published_at }.from(nil) .to not_change { terms.reload.published_at }.from(nil)
.and not_change(Admin::ActionLog, :count) .and not_change(Admin::ActionLog, :count)
expect(page) expect(page)
.to have_title(I18n.t('admin.terms_of_service.title')) .to have_title(I18n.t('admin.terms_of_service.title'))
# Valid with publish button # Valid with publish button
fill_in 'terms_of_service_text', with: 'newer' fill_in 'terms_of_service_text', with: 'newer'
expect { click_on I18n.t('admin.terms_of_service.publish') } expect { click_on I18n.t('admin.terms_of_service.publish') }
.to change { terms.reload.published_at }.from(nil) .to change { terms.reload.published_at }.from(nil)
.and change(Admin::ActionLog, :count) .and change(Admin::ActionLog, :count)
expect(page) expect(page)
.to have_title(I18n.t('admin.terms_of_service.title')) .to have_title(I18n.t('admin.terms_of_service.title'))
end
end
context 'when a live TOS record exists' do
before do
travel_to 5.days.ago do
Fabricate :terms_of_service, published_at: 2.days.ago, effective_date: 1.day.from_now
end
end
it 'populates an unsaved record with prior text' do
visit admin_terms_of_service_draft_path
expect(page)
.to have_title(I18n.t('admin.terms_of_service.title'))
# Valid submission with draft button
expect { click_on I18n.t('admin.terms_of_service.save_draft') }
.to change(TermsOfService, :count).by(1)
.and not_change(Admin::ActionLog, :count)
expect(TermsOfService.current.text)
.to eq(TermsOfService.draft.last.text)
expect(page)
.to have_title(I18n.t('admin.terms_of_service.title'))
end
end
context 'when there are no TOS records' do
it 'builds an unsaved record for editing' do
visit admin_terms_of_service_draft_path
expect(page)
.to have_title(I18n.t('admin.terms_of_service.title'))
# Valid submission with draft button
fill_in 'terms_of_service_text', with: 'new'
expect { click_on I18n.t('admin.terms_of_service.save_draft') }
.to change(TermsOfService, :count).by(1)
.and not_change(Admin::ActionLog, :count)
expect(page)
.to have_title(I18n.t('admin.terms_of_service.title'))
end
end end
end end
end end