From f7259f625feb8e19d337d122ff6c8c61ec4b488e Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Wed, 9 Jul 2025 04:03:39 -0400 Subject: [PATCH] Prefer `on: :update` in Tag validation declaration (#35297) --- app/models/tag.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/tag.rb b/app/models/tag.rb index a3ccdd8ac6b..8e21ddca82b 100644 --- a/app/models/tag.rb +++ b/app/models/tag.rb @@ -49,8 +49,8 @@ class Tag < ApplicationRecord validates :name, presence: true, format: { with: HASHTAG_NAME_RE } validates :display_name, format: { with: HASHTAG_NAME_RE } - validate :validate_name_change, if: -> { !new_record? && name_changed? } - validate :validate_display_name_change, if: -> { !new_record? && display_name_changed? } + validate :validate_name_change, on: :update, if: :name_changed? + validate :validate_display_name_change, on: :update, if: :display_name_changed? scope :pending_review, -> { unreviewed.where.not(requested_review_at: nil) } scope :usable, -> { where(usable: [true, nil]) }