add some more docu, turn of caching in getApprovalStatus()

see FIXME comment
This commit is contained in:
Uwe Steinmann 2013-10-06 08:09:37 +02:00
parent fcffe34047
commit 633ae6e7e6

View File

@ -2291,7 +2291,7 @@ class SeedDMS_Core_DocumentContent extends SeedDMS_Core_Object { /* {{{ */
/** /**
* Get the current review status of the document content * Get the current review status of the document content
* The review status is a list of reviewers and its current status * The review status is a list of reviews and its current status
* *
* @param integer $limit the number of recent status changes per reviewer * @param integer $limit the number of recent status changes per reviewer
* @return array list of review status * @return array list of review status
@ -2303,7 +2303,9 @@ class SeedDMS_Core_DocumentContent extends SeedDMS_Core_Object { /* {{{ */
// Retrieve the current status of each assigned reviewer for the content // Retrieve the current status of each assigned reviewer for the content
// represented by this object. // represented by this object.
if (!isset($this->_reviewStatus)) { // FIXME: caching was turned off to make list of review log in ViewDocument
// possible
if (1 || !isset($this->_reviewStatus)) {
/* First get a list of all reviews for this document content */ /* First get a list of all reviews for this document content */
$queryStr= $queryStr=
"SELECT reviewID FROM tblDocumentReviewers WHERE `version`='".$this->_version "SELECT reviewID FROM tblDocumentReviewers WHERE `version`='".$this->_version
@ -2337,6 +2339,13 @@ class SeedDMS_Core_DocumentContent extends SeedDMS_Core_Object { /* {{{ */
return $this->_reviewStatus; return $this->_reviewStatus;
} /* }}} */ } /* }}} */
/**
* Get the current approval status of the document content
* The approval status is a list of approvals and its current status
*
* @param integer $limit the number of recent status changes per approver
* @return array list of approval status
*/
function getApprovalStatus($limit=1) { /* {{{ */ function getApprovalStatus($limit=1) { /* {{{ */
$db = $this->_document->_dms->getDB(); $db = $this->_document->_dms->getDB();
@ -2344,7 +2353,9 @@ class SeedDMS_Core_DocumentContent extends SeedDMS_Core_Object { /* {{{ */
// Retrieve the current status of each assigned approver for the content // Retrieve the current status of each assigned approver for the content
// represented by this object. // represented by this object.
if (!isset($this->_approvalStatus)) { // FIXME: caching was turned off to make list of approval log in ViewDocument
// possible
if (1 || !isset($this->_approvalStatus)) {
/* First get a list of all approvals for this document content */ /* First get a list of all approvals for this document content */
$queryStr= $queryStr=
"SELECT approveID FROM tblDocumentApprovers WHERE `version`='".$this->_version "SELECT approveID FROM tblDocumentApprovers WHERE `version`='".$this->_version