From 22c1b6f3eec14062c6e0950fdb2d436c34430543 Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Fri, 10 Jan 2025 15:34:18 -0500
Subject: [PATCH] Fix `Invite#code` changing value on every save (#33550)

---
 app/models/invite.rb       |  2 +-
 spec/models/invite_spec.rb | 45 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 1 deletion(-)

diff --git a/app/models/invite.rb b/app/models/invite.rb
index d1981f16ad7..9437ebee60b 100644
--- a/app/models/invite.rb
+++ b/app/models/invite.rb
@@ -31,7 +31,7 @@ class Invite < ApplicationRecord
 
   validates :comment, length: { maximum: COMMENT_SIZE_LIMIT }
 
-  before_validation :set_code
+  before_validation :set_code, on: :create
 
   def valid_for_use?
     (max_uses.nil? || uses < max_uses) && !expired? && user&.functional?
diff --git a/spec/models/invite_spec.rb b/spec/models/invite_spec.rb
index e85885a8d8b..6363f77a646 100644
--- a/spec/models/invite_spec.rb
+++ b/spec/models/invite_spec.rb
@@ -5,6 +5,29 @@ require 'rails_helper'
 RSpec.describe Invite do
   include_examples 'Expireable'
 
+  describe 'Associations' do
+    it { is_expected.to belong_to(:user).inverse_of(:invites) }
+    it { is_expected.to have_many(:users).inverse_of(:invite) }
+  end
+
+  describe 'Validations' do
+    it { is_expected.to validate_length_of(:comment).is_at_most(described_class::COMMENT_SIZE_LIMIT) }
+  end
+
+  describe 'Scopes' do
+    describe '.available' do
+      let!(:no_expires) { Fabricate :invite, expires_at: nil }
+      let!(:past_expires) { Fabricate :invite, expires_at: 2.days.ago }
+      let!(:future_expires) { Fabricate :invite, expires_at: 2.days.from_now }
+
+      it 'returns future and non-epiring records' do
+        expect(described_class.available)
+          .to include(no_expires, future_expires)
+          .and not_include(past_expires)
+      end
+    end
+  end
+
   describe '#valid_for_use?' do
     it 'returns true when there are no limitations' do
       invite = Fabricate(:invite, max_uses: nil, expires_at: nil)
@@ -37,4 +60,26 @@ RSpec.describe Invite do
       expect(invite.valid_for_use?).to be false
     end
   end
+
+  describe 'Callbacks' do
+    describe 'Setting the invite code' do
+      context 'when creating a new record' do
+        subject { Fabricate.build :invite }
+
+        it 'sets a code value' do
+          expect { subject.save }
+            .to change(subject, :code).from(be_blank).to(be_present)
+        end
+      end
+
+      context 'when updating a record' do
+        subject { Fabricate :invite }
+
+        it 'does not change the code value' do
+          expect { subject.update(max_uses: 123_456) }
+            .to not_change(subject, :code)
+        end
+      end
+    end
+  end
 end