diff --git a/app/controllers/api/v1/statuses/translations_controller.rb b/app/controllers/api/v1/statuses/translations_controller.rb index 8cf495f78a..26aed5c7f6 100644 --- a/app/controllers/api/v1/statuses/translations_controller.rb +++ b/app/controllers/api/v1/statuses/translations_controller.rb @@ -23,6 +23,6 @@ class Api::V1::Statuses::TranslationsController < Api::V1::Statuses::BaseControl private def set_translation - @translation = TranslateStatusService.new.call(@status, content_locale) + @translation = TranslateStatusService.new.call(@status, params[:source_language], content_locale) end end diff --git a/app/javascript/mastodon/actions/importer/normalizer.js b/app/javascript/mastodon/actions/importer/normalizer.js index c09a3f442c..4b29c15d4d 100644 --- a/app/javascript/mastodon/actions/importer/normalizer.js +++ b/app/javascript/mastodon/actions/importer/normalizer.js @@ -101,6 +101,7 @@ export function normalizeStatusTranslation(translation, status) { const emojiMap = makeEmojiMap(status.get('emojis').toJS()); const normalTranslation = { + source_language: translation.source_language, detected_source_language: translation.detected_source_language, language: translation.language, provider: translation.provider, diff --git a/app/javascript/mastodon/actions/statuses.js b/app/javascript/mastodon/actions/statuses.js index 340cee8024..86f90d8aba 100644 --- a/app/javascript/mastodon/actions/statuses.js +++ b/app/javascript/mastodon/actions/statuses.js @@ -333,10 +333,10 @@ export function toggleStatusCollapse(id, isCollapsed) { }; } -export const translateStatus = id => (dispatch) => { +export const translateStatus = (id, source_language) => (dispatch) => { dispatch(translateStatusRequest(id)); - api().post(`/api/v1/statuses/${id}/translate`).then(response => { + api().post(`/api/v1/statuses/${id}/translate`, { source_language }).then(response => { dispatch(translateStatusSuccess(id, response.data)); }).catch(error => { dispatch(translateStatusFail(id, error)); diff --git a/app/javascript/mastodon/components/status.jsx b/app/javascript/mastodon/components/status.jsx index 7236c9633d..9f5a6dd3a4 100644 --- a/app/javascript/mastodon/components/status.jsx +++ b/app/javascript/mastodon/components/status.jsx @@ -106,6 +106,7 @@ class Status extends ImmutablePureComponent { onToggleHidden: PropTypes.func, onToggleCollapsed: PropTypes.func, onTranslate: PropTypes.func, + onUndoStatusTranslation: PropTypes.func, onInteractionModal: PropTypes.func, muted: PropTypes.bool, hidden: PropTypes.bool, @@ -200,8 +201,12 @@ class Status extends ImmutablePureComponent { this.props.onToggleCollapsed(this._properStatus(), isCollapsed); }; - handleTranslate = () => { - this.props.onTranslate(this._properStatus()); + handleTranslate = (sourceLanguage) => { + this.props.onTranslate(this._properStatus(), sourceLanguage); + }; + + handleUndoStatusTranslation = () => { + this.props.onUndoStatusTranslation(this._properStatus()); }; getAttachmentAspectRatio () { @@ -579,6 +584,7 @@ class Status extends ImmutablePureComponent { status={status} onClick={this.handleClick} onTranslate={this.handleTranslate} + onUndoStatusTranslation={this.handleUndoStatusTranslation} collapsible onCollapsedToggle={this.handleCollapsedToggle} {...statusContentProps} diff --git a/app/javascript/mastodon/components/status_content.jsx b/app/javascript/mastodon/components/status_content.jsx index 3316be8350..f388a85fe9 100644 --- a/app/javascript/mastodon/components/status_content.jsx +++ b/app/javascript/mastodon/components/status_content.jsx @@ -30,32 +30,47 @@ class TranslateButton extends PureComponent { static propTypes = { translation: ImmutablePropTypes.map, - onClick: PropTypes.func, + onTranslate: PropTypes.func, + onDetectLanguage: PropTypes.func, + onUndoStatusTranslation: PropTypes.func, }; render () { - const { translation, onClick } = this.props; + const { translation, onTranslate, onDetectLanguage, onUndoStatusTranslation } = this.props; if (translation) { const language = preloadedLanguages.find(lang => lang[0] === translation.get('detected_source_language')); const languageName = language ? language[2] : translation.get('detected_source_language'); const provider = translation.get('provider'); + const languageDetectionButton = onDetectLanguage && ( + <> + + ยท + + ); + return (
- +
+ {languageDetectionButton} + + +
); } return ( - ); @@ -73,6 +88,7 @@ class StatusContent extends PureComponent { status: ImmutablePropTypes.map.isRequired, statusContent: PropTypes.string, onTranslate: PropTypes.func, + onUndoStatusTranslation: PropTypes.func, onClick: PropTypes.func, collapsible: PropTypes.bool, onCollapsedToggle: PropTypes.func, @@ -215,6 +231,10 @@ class StatusContent extends PureComponent { this.props.onTranslate(); }; + handleDetectLanguage = () => { + this.props.onTranslate('und'); + }; + setRef = (c) => { this.node = c; }; @@ -224,9 +244,13 @@ class StatusContent extends PureComponent { const renderReadMore = this.props.onClick && status.get('collapsed'); const contentLocale = intl.locale.replace(/[_-].*/, ''); - const targetLanguages = this.props.languages?.get(status.get('language') || 'und'); + const sourceLanguage = status.get('language') || 'und'; + const targetLanguages = this.props.languages?.get(sourceLanguage); const renderTranslate = this.props.onTranslate && this.props.identity.signedIn && ['public', 'unlisted'].includes(status.get('visibility')) && status.get('search_index').trim().length > 0 && targetLanguages?.includes(contentLocale); + const languageDetectionTargetLanguages = this.props.languages?.get('und'); + const renderDetectLanguage = sourceLanguage !== 'und' && languageDetectionTargetLanguages?.includes(contentLocale) && status.get('translation')?.get('source_language') !== 'und'; + const content = { __html: statusContent ?? getStatusContent(status) }; const language = status.getIn(['translation', 'language']) || status.get('language'); const classNames = classnames('status__content', { @@ -241,7 +265,12 @@ class StatusContent extends PureComponent { ); const translateButton = renderTranslate && ( - + ); const poll = !!status.get('poll') && ( diff --git a/app/javascript/mastodon/containers/status_container.jsx b/app/javascript/mastodon/containers/status_container.jsx index 58c5aac8f8..2bde39ed9f 100644 --- a/app/javascript/mastodon/containers/status_container.jsx +++ b/app/javascript/mastodon/containers/status_container.jsx @@ -126,12 +126,12 @@ const mapDispatchToProps = (dispatch, { contextType }) => ({ }); }, - onTranslate (status) { - if (status.get('translation')) { - dispatch(undoStatusTranslation(status.get('id'), status.get('poll'))); - } else { - dispatch(translateStatus(status.get('id'))); - } + onTranslate (status, sourceLanguage) { + dispatch(translateStatus(status.get('id'), sourceLanguage)); + }, + + onUndoStatusTranslation (status) { + dispatch(undoStatusTranslation(status.get('id'), status.get('poll'))); }, onDirect (account) { diff --git a/app/javascript/mastodon/features/status/components/detailed_status.jsx b/app/javascript/mastodon/features/status/components/detailed_status.jsx index 8ee1ec9b9b..4dc0223716 100644 --- a/app/javascript/mastodon/features/status/components/detailed_status.jsx +++ b/app/javascript/mastodon/features/status/components/detailed_status.jsx @@ -36,6 +36,7 @@ class DetailedStatus extends ImmutablePureComponent { onOpenVideo: PropTypes.func.isRequired, onToggleHidden: PropTypes.func.isRequired, onTranslate: PropTypes.func.isRequired, + onUndoStatusTranslation: PropTypes.func.isRequired, measureHeight: PropTypes.bool, onHeightChange: PropTypes.func, domain: PropTypes.string.isRequired, @@ -103,9 +104,14 @@ class DetailedStatus extends ImmutablePureComponent { window.open(href, 'mastodon-intent', 'width=445,height=600,resizable=no,menubar=no,status=no,scrollbars=yes'); }; - handleTranslate = () => { + handleTranslate = (sourceLanguage) => { const { onTranslate, status } = this.props; - onTranslate(status); + onTranslate(status, sourceLanguage); + }; + + handleUndoStatusTranslation = () => { + const { onUndoStatusTranslation, status } = this.props; + onUndoStatusTranslation(status); }; _properStatus () { @@ -285,6 +291,7 @@ class DetailedStatus extends ImmutablePureComponent { diff --git a/app/javascript/mastodon/features/status/index.jsx b/app/javascript/mastodon/features/status/index.jsx index 5f325fe7b8..a9d24317a4 100644 --- a/app/javascript/mastodon/features/status/index.jsx +++ b/app/javascript/mastodon/features/status/index.jsx @@ -392,14 +392,16 @@ class Status extends ImmutablePureComponent { } }; - handleTranslate = status => { + handleTranslate = (status, sourceLanguage) => { const { dispatch } = this.props; - if (status.get('translation')) { - dispatch(undoStatusTranslation(status.get('id'), status.get('poll'))); - } else { - dispatch(translateStatus(status.get('id'))); - } + dispatch(translateStatus(status.get('id'), sourceLanguage)); + }; + + handleUndoStatusTranslation = status => { + const { dispatch } = this.props; + + dispatch(undoStatusTranslation(status.get('id'), status.get('poll'))); }; handleBlockClick = (status) => { @@ -675,6 +677,7 @@ class Status extends ImmutablePureComponent { onOpenMedia={this.handleOpenMedia} onToggleHidden={this.handleToggleHidden} onTranslate={this.handleTranslate} + onUndoStatusTranslation={this.handleUndoStatusTranslation} domain={domain} showMedia={this.state.showMedia} onToggleMediaVisibility={this.handleToggleMediaVisibility} diff --git a/app/javascript/mastodon/locales/en.json b/app/javascript/mastodon/locales/en.json index 88920431fb..af66752958 100644 --- a/app/javascript/mastodon/locales/en.json +++ b/app/javascript/mastodon/locales/en.json @@ -779,6 +779,7 @@ "status.copy": "Copy link to post", "status.delete": "Delete", "status.detailed_status": "Detailed conversation view", + "status.detect_language": "Detect language", "status.direct": "Privately mention @{name}", "status.direct_indicator": "Private mention", "status.edit": "Edit", diff --git a/app/javascript/styles/mastodon/components.scss b/app/javascript/styles/mastodon/components.scss index 6157a83af4..a55dcfdd28 100644 --- a/app/javascript/styles/mastodon/components.scss +++ b/app/javascript/styles/mastodon/components.scss @@ -1312,6 +1312,17 @@ body > [data-popper-placement] { display: flex; justify-content: space-between; color: $dark-text-color; + + .translate-button__buttons { + margin-right: -6px; + float: right; + white-space: nowrap; + + .link-button { + display: inline; + margin: 0 6px; + } + } } .status__content__spoiler-link { diff --git a/app/lib/translation_service/deepl.rb b/app/lib/translation_service/deepl.rb index 925a1cf172..bae746e3c8 100644 --- a/app/lib/translation_service/deepl.rb +++ b/app/lib/translation_service/deepl.rb @@ -11,6 +11,7 @@ class TranslationService::DeepL < TranslationService end def translate(texts, source_language, target_language) + source_language = nil if source_language == 'und' form = { text: texts, source_lang: source_language&.upcase, target_lang: target_language, tag_handling: 'html' } request(:post, '/v2/translate', form: form) do |res| transform_response(res.body_with_limit) @@ -18,7 +19,7 @@ class TranslationService::DeepL < TranslationService end def languages - source_languages = [nil] + fetch_languages('source') + source_languages = ['und'] + fetch_languages('source') # In DeepL, EN and PT are deprecated in favor of EN-GB/EN-US and PT-BR/PT-PT, so # they are supported but not returned by the API. diff --git a/app/lib/translation_service/libre_translate.rb b/app/lib/translation_service/libre_translate.rb index de43d7c88c..7335d014c8 100644 --- a/app/lib/translation_service/libre_translate.rb +++ b/app/lib/translation_service/libre_translate.rb @@ -9,7 +9,8 @@ class TranslationService::LibreTranslate < TranslationService end def translate(texts, source_language, target_language) - body = Oj.dump(q: texts, source: source_language.presence || 'auto', target: target_language, format: 'html', api_key: @api_key) + source_language = 'auto' if source_language.in? [nil, 'und'] + body = Oj.dump(q: texts, source: source_language, target: target_language, format: 'html', api_key: @api_key) request(:post, '/translate', body: body) do |res| transform_response(res.body_with_limit, source_language) end @@ -20,7 +21,7 @@ class TranslationService::LibreTranslate < TranslationService languages = Oj.load(res.body_with_limit).to_h do |language| [language['code'], language['targets'].without(language['code'])] end - languages[nil] = languages.values.flatten.uniq.sort + languages['und'] = languages.values.flatten.uniq.sort languages end end diff --git a/app/models/translation.rb b/app/models/translation.rb index 7f8469c86e..97ef7deece 100644 --- a/app/models/translation.rb +++ b/app/models/translation.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true class Translation < ActiveModelSerializers::Model - attributes :status, :detected_source_language, :language, :provider, + attributes :status, :source_language, :detected_source_language, :language, :provider, :content, :spoiler_text, :poll_options, :media_attachments class Option < ActiveModelSerializers::Model diff --git a/app/serializers/rest/translation_serializer.rb b/app/serializers/rest/translation_serializer.rb index 40e2d28fb7..653efe6a12 100644 --- a/app/serializers/rest/translation_serializer.rb +++ b/app/serializers/rest/translation_serializer.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true class REST::TranslationSerializer < ActiveModel::Serializer - attributes :detected_source_language, :language, :provider, :spoiler_text, :content + attributes :source_language, :detected_source_language, :language, :provider, :spoiler_text, :content class PollSerializer < ActiveModel::Serializer attribute :id diff --git a/app/services/translate_status_service.rb b/app/services/translate_status_service.rb index 9ad146ae7d..6b08e2dd5b 100644 --- a/app/services/translate_status_service.rb +++ b/app/services/translate_status_service.rb @@ -6,15 +6,16 @@ class TranslateStatusService < BaseService include ERB::Util include FormattingHelper - def call(status, target_language) + def call(status, source_language, target_language) @status = status @source_texts = source_texts + @source_language = source_language || @status.language.presence || 'und' @target_language = target_language raise Mastodon::NotPermittedError unless permitted? - status_translation = Rails.cache.fetch("v2:translations/#{@status.language}/#{@target_language}/#{content_hash}", expires_in: CACHE_TTL) do - translations = translation_backend.translate(@source_texts.values, @status.language, @target_language) + status_translation = Rails.cache.fetch("v3:translations/#{@source_language}/#{@target_language}/#{content_hash}", expires_in: CACHE_TTL) do + translations = translation_backend.translate(@source_texts.values, @source_language, @target_language) build_status_translation(translations) end @@ -32,11 +33,11 @@ class TranslateStatusService < BaseService def permitted? return false unless @status.distributable? && TranslationService.configured? - languages[@status.language]&.include?(@target_language) + languages[@source_language]&.include?(@target_language) end def languages - Rails.cache.fetch('translation_service/languages', expires_in: 7.days, race_condition_ttl: 1.hour) { TranslationService.configured.languages } + Rails.cache.fetch('v2:translation_service/languages', expires_in: 7.days, race_condition_ttl: 1.hour) { TranslationService.configured.languages } end def content_hash @@ -61,6 +62,7 @@ class TranslateStatusService < BaseService def build_status_translation(translations) status_translation = Translation.new( + source_language: @source_language, detected_source_language: translations.first&.detected_source_language, language: @target_language, provider: translations.first&.provider,