diff --git a/app/javascript/mastodon/components/media_gallery.jsx b/app/javascript/mastodon/components/media_gallery.jsx index 64250236d8..b0f60080e8 100644 --- a/app/javascript/mastodon/components/media_gallery.jsx +++ b/app/javascript/mastodon/components/media_gallery.jsx @@ -17,6 +17,14 @@ import { formatTime } from 'mastodon/features/video'; import { autoPlayGif, displayMedia, useBlurhash } from '../initial_state'; +const colCount = function(size) { + return Math.max(Math.ceil(Math.sqrt(size)), 2); +}; + +const rowCount = function(size) { + return Math.ceil(size / colCount(size)); +}; + class Item extends PureComponent { static propTypes = { @@ -93,14 +101,18 @@ class Item extends PureComponent { let badges = [], thumbnail; let width = 50; - let height = 100; + let height = 50; - if (size === 1) { + const cols = colCount(size); + const remaining = (-size % cols + cols) % cols; + const largeCount = Math.floor(remaining / 3); // width=2, height=2 + const mediumCount = remaining % 3; // height=2 + + if (size === 1 || index < largeCount) { width = 100; - } - - if (size === 4 || (size === 3 && index > 0)) { - height = 50; + height = 100; + } else if (size === 2 || index < largeCount + mediumCount) { + height = 100; } const description = attachment.getIn(['translation', 'description']) || attachment.get('description'); @@ -308,6 +320,11 @@ class MediaGallery extends PureComponent { if (this.isFullSizeEligible()) { style.aspectRatio = `${this.props.media.getIn([0, 'meta', 'small', 'aspect'])}`; } else { + const cols = colCount(media.size); + const rows = rowCount(media.size); + style.gridTemplateColumns = `repeat(${cols}, 1fr)`; + style.gridTemplateRows = `repeat(${rows}, 1fr)`; + style.aspectRatio = '3 / 2'; } diff --git a/app/lib/activitypub/activity/create.rb b/app/lib/activitypub/activity/create.rb index 06bc940949..3d607926a5 100644 --- a/app/lib/activitypub/activity/create.rb +++ b/app/lib/activitypub/activity/create.rb @@ -90,7 +90,7 @@ class ActivityPub::Activity::Create < ActivityPub::Activity object: @object ) - attachment_ids = process_attachments.take(Status::MEDIA_ATTACHMENTS_LIMIT).map(&:id) + attachment_ids = process_attachments.take(Status::REMOTE_MEDIA_ATTACHMENTS_LIMIT).map(&:id) @params = { uri: @status_parser.uri, @@ -287,7 +287,7 @@ class ActivityPub::Activity::Create < ActivityPub::Activity as_array(@object['attachment']).each do |attachment| media_attachment_parser = ActivityPub::Parser::MediaAttachmentParser.new(attachment) - next if media_attachment_parser.remote_url.blank? || media_attachments.size >= Status::MEDIA_ATTACHMENTS_LIMIT + next if media_attachment_parser.remote_url.blank? || media_attachments.size >= Status::REMOTE_MEDIA_ATTACHMENTS_LIMIT begin media_attachment = MediaAttachment.create( diff --git a/app/models/status.rb b/app/models/status.rb index 5e89fc3531..5f85dc8281 100644 --- a/app/models/status.rb +++ b/app/models/status.rb @@ -44,6 +44,7 @@ class Status < ApplicationRecord include Status::Visibility MEDIA_ATTACHMENTS_LIMIT = 4 + REMOTE_MEDIA_ATTACHMENTS_LIMIT = 16 QUOTE_APPROVAL_POLICY_FLAGS = { unknown: (1 << 0), @@ -278,6 +279,10 @@ class Status < ApplicationRecord @emojis = CustomEmoji.from_text(fields.join(' '), account.domain) end + def media_attachments_limit + local? ? MEDIA_ATTACHMENTS_LIMIT : REMOTE_MEDIA_ATTACHMENTS_LIMIT + end + def ordered_media_attachments if ordered_media_attachment_ids.nil? # NOTE: sort Ruby-side to avoid hitting the database when the status is @@ -286,7 +291,7 @@ class Status < ApplicationRecord else map = media_attachments.index_by(&:id) ordered_media_attachment_ids.filter_map { |media_attachment_id| map[media_attachment_id] } - end.take(MEDIA_ATTACHMENTS_LIMIT) + end.take(media_attachments_limit) end def replies_count diff --git a/app/models/status_edit.rb b/app/models/status_edit.rb index a64ef34905..8016433158 100644 --- a/app/models/status_edit.rb +++ b/app/models/status_edit.rb @@ -61,7 +61,7 @@ class StatusEdit < ApplicationRecord map = status.media_attachments.index_by(&:id) ordered_media_attachment_ids.map.with_index { |media_attachment_id, index| PreservedMediaAttachment.new(media_attachment: map[media_attachment_id], description: media_descriptions[index]) } end - end.take(Status::MEDIA_ATTACHMENTS_LIMIT) + end.take(status.media_attachments_limit) end def proper diff --git a/app/services/activitypub/process_status_update_service.rb b/app/services/activitypub/process_status_update_service.rb index aceb17f2d1..9f780bb259 100644 --- a/app/services/activitypub/process_status_update_service.rb +++ b/app/services/activitypub/process_status_update_service.rb @@ -82,7 +82,7 @@ class ActivityPub::ProcessStatusUpdateService < BaseService as_array(@json['attachment']).each do |attachment| media_attachment_parser = ActivityPub::Parser::MediaAttachmentParser.new(attachment) - next if media_attachment_parser.remote_url.blank? || @next_media_attachments.size > Status::MEDIA_ATTACHMENTS_LIMIT + next if media_attachment_parser.remote_url.blank? || @next_media_attachments.size > Status::REMOTE_MEDIA_ATTACHMENTS_LIMIT begin media_attachment = previous_media_attachments.find { |previous_media_attachment| previous_media_attachment.remote_url == media_attachment_parser.remote_url }