diff --git a/app/javascript/mastodon/components/follow_button.tsx b/app/javascript/mastodon/components/follow_button.tsx
index 98ef3ba3f1c..15a9046848f 100644
--- a/app/javascript/mastodon/components/follow_button.tsx
+++ b/app/javascript/mastodon/components/follow_button.tsx
@@ -5,24 +5,61 @@ import { useIntl, defineMessages } from 'react-intl';
import classNames from 'classnames';
import { useIdentity } from '@/mastodon/identity_context';
-import { fetchRelationships, followAccount } from 'mastodon/actions/accounts';
+import {
+ fetchRelationships,
+ followAccount,
+ unblockAccount,
+ unmuteAccount,
+} from 'mastodon/actions/accounts';
import { openModal } from 'mastodon/actions/modal';
import { Button } from 'mastodon/components/button';
import { LoadingIndicator } from 'mastodon/components/loading_indicator';
import { me } from 'mastodon/initial_state';
import { useAppDispatch, useAppSelector } from 'mastodon/store';
-const messages = defineMessages({
+import { useBreakpoint } from '../features/ui/hooks/useBreakpoint';
+
+const longMessages = defineMessages({
unfollow: { id: 'account.unfollow', defaultMessage: 'Unfollow' },
+ unblock: { id: 'account.unblock_short', defaultMessage: 'Unblock' },
+ unmute: { id: 'account.unmute_short', defaultMessage: 'Unmute' },
follow: { id: 'account.follow', defaultMessage: 'Follow' },
followBack: { id: 'account.follow_back', defaultMessage: 'Follow back' },
+ followRequest: {
+ id: 'account.follow_request',
+ defaultMessage: 'Request to follow',
+ },
+ followRequestCancel: {
+ id: 'account.follow_request_cancel',
+ defaultMessage: 'Cancel request',
+ },
editProfile: { id: 'account.edit_profile', defaultMessage: 'Edit profile' },
});
+const shortMessages = {
+ ...longMessages, // Align type signature of shortMessages and longMessages
+ ...defineMessages({
+ followBack: {
+ id: 'account.follow_back_short',
+ defaultMessage: 'Follow back',
+ },
+ followRequest: {
+ id: 'account.follow_request_short',
+ defaultMessage: 'Request',
+ },
+ followRequestCancel: {
+ id: 'account.follow_request_cancel_short',
+ defaultMessage: 'Cancel',
+ },
+ editProfile: { id: 'account.edit_profile_short', defaultMessage: 'Edit' },
+ }),
+};
+
export const FollowButton: React.FC<{
accountId?: string;
compact?: boolean;
-}> = ({ accountId, compact }) => {
+ labelLength?: 'auto' | 'short' | 'long';
+}> = ({ accountId, compact, labelLength = 'auto' }) => {
const intl = useIntl();
const dispatch = useAppDispatch();
const { signedIn } = useIdentity();
@@ -57,29 +94,48 @@ export const FollowButton: React.FC<{
if (accountId === me) {
return;
+ } else if (relationship.muting) {
+ dispatch(unmuteAccount(accountId));
} else if (account && (relationship.following || relationship.requested)) {
dispatch(
openModal({ modalType: 'CONFIRM_UNFOLLOW', modalProps: { account } }),
);
+ } else if (relationship.blocking) {
+ dispatch(unblockAccount(accountId));
} else {
dispatch(followAccount(accountId));
}
}, [dispatch, accountId, relationship, account, signedIn]);
+ const isNarrow = useBreakpoint('narrow');
+ const useShortLabel =
+ labelLength === 'short' || (labelLength === 'auto' && isNarrow);
+ const messages = useShortLabel ? shortMessages : longMessages;
+
+ const followMessage = account?.locked
+ ? messages.followRequest
+ : messages.follow;
+
let label;
if (!signedIn) {
- label = intl.formatMessage(messages.follow);
+ label = intl.formatMessage(followMessage);
} else if (accountId === me) {
label = intl.formatMessage(messages.editProfile);
} else if (!relationship) {
label = ;
- } else if (relationship.following || relationship.requested) {
+ } else if (relationship.muting) {
+ label = intl.formatMessage(messages.unmute);
+ } else if (relationship.following) {
label = intl.formatMessage(messages.unfollow);
- } else if (relationship.followed_by) {
+ } else if (relationship.blocking) {
+ label = intl.formatMessage(messages.unblock);
+ } else if (relationship.requested) {
+ label = intl.formatMessage(messages.followRequestCancel);
+ } else if (relationship.followed_by && !account?.locked) {
label = intl.formatMessage(messages.followBack);
} else {
- label = intl.formatMessage(messages.follow);
+ label = intl.formatMessage(followMessage);
}
if (accountId === me) {
diff --git a/app/javascript/mastodon/features/directory/components/account_card.tsx b/app/javascript/mastodon/features/directory/components/account_card.tsx
index 9d317efd437..6dc70532ab0 100644
--- a/app/javascript/mastodon/features/directory/components/account_card.tsx
+++ b/app/javascript/mastodon/features/directory/components/account_card.tsx
@@ -1,134 +1,23 @@
-import { useCallback } from 'react';
+import { FormattedMessage } from 'react-intl';
-import { FormattedMessage, defineMessages, useIntl } from 'react-intl';
-
-import classNames from 'classnames';
import { Link } from 'react-router-dom';
-import {
- followAccount,
- unblockAccount,
- unmuteAccount,
-} from 'mastodon/actions/accounts';
-import { openModal } from 'mastodon/actions/modal';
import { Avatar } from 'mastodon/components/avatar';
-import { Button } from 'mastodon/components/button';
import { DisplayName } from 'mastodon/components/display_name';
+import { FollowButton } from 'mastodon/components/follow_button';
import { ShortNumber } from 'mastodon/components/short_number';
-import { autoPlayGif, me } from 'mastodon/initial_state';
+import { autoPlayGif } from 'mastodon/initial_state';
import type { Account } from 'mastodon/models/account';
import { makeGetAccount } from 'mastodon/selectors';
-import { useAppDispatch, useAppSelector } from 'mastodon/store';
-
-const messages = defineMessages({
- unfollow: { id: 'account.unfollow', defaultMessage: 'Unfollow' },
- follow: { id: 'account.follow', defaultMessage: 'Follow' },
- cancel_follow_request: {
- id: 'account.cancel_follow_request',
- defaultMessage: 'Withdraw follow request',
- },
- requested: {
- id: 'account.requested',
- defaultMessage: 'Awaiting approval. Click to cancel follow request',
- },
- unblock: { id: 'account.unblock_short', defaultMessage: 'Unblock' },
- unmute: { id: 'account.unmute_short', defaultMessage: 'Unmute' },
- edit_profile: { id: 'account.edit_profile', defaultMessage: 'Edit profile' },
-});
+import { useAppSelector } from 'mastodon/store';
const getAccount = makeGetAccount();
export const AccountCard: React.FC<{ accountId: string }> = ({ accountId }) => {
- const intl = useIntl();
const account = useAppSelector((s) => getAccount(s, accountId));
- const dispatch = useAppDispatch();
-
- const handleFollow = useCallback(() => {
- if (!account) return;
-
- if (
- account.getIn(['relationship', 'following']) ||
- account.getIn(['relationship', 'requested'])
- ) {
- dispatch(
- openModal({ modalType: 'CONFIRM_UNFOLLOW', modalProps: { account } }),
- );
- } else {
- dispatch(followAccount(account.get('id')));
- }
- }, [account, dispatch]);
-
- const handleBlock = useCallback(() => {
- if (account?.relationship?.blocking) {
- dispatch(unblockAccount(account.get('id')));
- }
- }, [account, dispatch]);
-
- const handleMute = useCallback(() => {
- if (account?.relationship?.muting) {
- dispatch(unmuteAccount(account.get('id')));
- }
- }, [account, dispatch]);
-
- const handleEditProfile = useCallback(() => {
- window.open('/settings/profile', '_blank');
- }, []);
if (!account) return null;
- let actionBtn;
-
- if (me !== account.get('id')) {
- if (!account.get('relationship')) {
- // Wait until the relationship is loaded
- actionBtn = '';
- } else if (account.getIn(['relationship', 'requested'])) {
- actionBtn = (
-
- );
- } else if (account.getIn(['relationship', 'muting'])) {
- actionBtn = (
-
- );
- } else if (!account.getIn(['relationship', 'blocking'])) {
- actionBtn = (
-
- );
- } else if (account.getIn(['relationship', 'blocking'])) {
- actionBtn = (
-
- );
- }
- } else {
- actionBtn = (
-
- );
- }
-
return (
@@ -186,7 +75,9 @@ export const AccountCard: React.FC<{ accountId: string }> = ({ accountId }) => {
- {actionBtn}
+
+
+
);
diff --git a/app/javascript/mastodon/features/home_timeline/components/inline_follow_suggestions.tsx b/app/javascript/mastodon/features/home_timeline/components/inline_follow_suggestions.tsx
index 3df6d67ecf6..05799ccb824 100644
--- a/app/javascript/mastodon/features/home_timeline/components/inline_follow_suggestions.tsx
+++ b/app/javascript/mastodon/features/home_timeline/components/inline_follow_suggestions.tsx
@@ -25,8 +25,6 @@ import { domain } from 'mastodon/initial_state';
import { useAppDispatch, useAppSelector } from 'mastodon/store';
const messages = defineMessages({
- follow: { id: 'account.follow', defaultMessage: 'Follow' },
- unfollow: { id: 'account.unfollow', defaultMessage: 'Unfollow' },
previous: { id: 'lightbox.previous', defaultMessage: 'Previous' },
next: { id: 'lightbox.next', defaultMessage: 'Next' },
dismiss: {
diff --git a/app/javascript/mastodon/features/ui/hooks/useBreakpoint.tsx b/app/javascript/mastodon/features/ui/hooks/useBreakpoint.tsx
index af96ab37663..cb7b3551f22 100644
--- a/app/javascript/mastodon/features/ui/hooks/useBreakpoint.tsx
+++ b/app/javascript/mastodon/features/ui/hooks/useBreakpoint.tsx
@@ -1,11 +1,12 @@
import { useState, useEffect } from 'react';
const breakpoints = {
+ narrow: 479, // Device width under which horizontal space is constrained
openable: 759, // Device width at which the sidebar becomes an openable hamburger menu
full: 1174, // Device width at which all 3 columns can be displayed
};
-type Breakpoint = 'openable' | 'full';
+type Breakpoint = keyof typeof breakpoints;
export const useBreakpoint = (breakpoint: Breakpoint) => {
const [isMatching, setIsMatching] = useState(false);
diff --git a/app/javascript/mastodon/locales/en.json b/app/javascript/mastodon/locales/en.json
index f949c303396..9dc405ab14a 100644
--- a/app/javascript/mastodon/locales/en.json
+++ b/app/javascript/mastodon/locales/en.json
@@ -28,6 +28,7 @@
"account.disable_notifications": "Stop notifying me when @{name} posts",
"account.domain_blocking": "Blocking domain",
"account.edit_profile": "Edit profile",
+ "account.edit_profile_short": "Edit",
"account.enable_notifications": "Notify me when @{name} posts",
"account.endorse": "Feature on profile",
"account.familiar_followers_many": "Followed by {name1}, {name2}, and {othersCount, plural, one {one other you know} other {# others you know}}",
@@ -40,6 +41,11 @@
"account.featured_tags.last_status_never": "No posts",
"account.follow": "Follow",
"account.follow_back": "Follow back",
+ "account.follow_back_short": "Follow back",
+ "account.follow_request": "Request to follow",
+ "account.follow_request_cancel": "Cancel request",
+ "account.follow_request_cancel_short": "Cancel",
+ "account.follow_request_short": "Request",
"account.followers": "Followers",
"account.followers.empty": "No one follows this user yet.",
"account.followers_counter": "{count, plural, one {{counter} follower} other {{counter} followers}}",
@@ -70,7 +76,6 @@
"account.posts_with_replies": "Posts and replies",
"account.remove_from_followers": "Remove {name} from followers",
"account.report": "Report @{name}",
- "account.requested": "Awaiting approval. Click to cancel follow request",
"account.requested_follow": "{name} has requested to follow you",
"account.requests_to_follow_you": "Requests to follow you",
"account.share": "Share @{name}'s profile",