Register an XML encoder for response tests (#32220)

spec/requests/well_known/host_meta_spec.rb

@@ -3,7 +3,8 @@
 require 'rails_helper'
 
 RSpec.describe 'The /.well-known/host-meta request' do
-  it 'returns http success with valid XML response' do
+  context 'without extension format or accept header' do
+    it 'returns http success with expected XML' do
       get '/.well-known/host-meta'
 
       expect(response)
@@ -12,12 +13,20 @@ RSpec.describe 'The /.well-known/host-meta request' do
           media_type: 'application/xrd+xml'
         )
 
-    doc = Nokogiri::XML(response.parsed_body)
-    expect(doc.at_xpath('/xrd:XRD/xrd:Link[@rel="lrdd"]/@template', 'xrd' => 'http://docs.oasis-open.org/ns/xri/xrd-1.0').value)
+      expect(xrd_link_template_value)
         .to eq 'https://cb6e6126.ngrok.io/.well-known/webfinger?resource={uri}'
     end
 
-  it 'returns http success with valid JSON response with .json extension' do
+    def xrd_link_template_value
+      response
+        .parsed_body
+        .at_xpath('/xrd:XRD/xrd:Link[@rel="lrdd"]/@template', 'xrd' => 'http://docs.oasis-open.org/ns/xri/xrd-1.0')
+        .value
+    end
+  end
+
+  context 'with a .json format extension' do
+    it 'returns http success with expected JSON' do
       get '/.well-known/host-meta.json'
 
       expect(response)
@@ -25,17 +34,13 @@ RSpec.describe 'The /.well-known/host-meta request' do
         .and have_attributes(
           media_type: 'application/json'
         )
-
       expect(response.parsed_body)
-      .to include(
-        links: [
-          'rel' => 'lrdd',
-          'template' => 'https://cb6e6126.ngrok.io/.well-known/webfinger?resource={uri}',
-        ]
-      )
+        .to include(expected_json_template)
+    end
   end
 
-  it 'returns http success with valid JSON response with Accept header' do
+  context 'with a JSON `Accept` header' do
+    it 'returns http success with expected JSON' do
       get '/.well-known/host-meta', headers: { 'Accept' => 'application/json' }
 
       expect(response)
@@ -43,5 +48,17 @@ RSpec.describe 'The /.well-known/host-meta request' do
         .and have_attributes(
           media_type: 'application/json'
         )
+      expect(response.parsed_body)
+        .to include(expected_json_template)
+    end
+  end
+
+  def expected_json_template
+    {
+      links: [
+        'rel' => 'lrdd',
+        'template' => 'https://cb6e6126.ngrok.io/.well-known/webfinger?resource={uri}',
+      ],
+    }
   end
 end

spec/support/response_encoders.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+ActionDispatch::IntegrationTest
+  .register_encoder :xml, response_parser: ->(body) { Nokogiri::XML(body) }