Merge a04273b06d into e9170e2de1

TwitterText already has a regex to check for valid domains that allows a
few domains the current Regex did not allow. Mainly it allows mentions
of accounts on domains with emoji in their domain names to be processed
correctly.

Mentions like `@test@🌈🌈🌈.st` will now work correctly.

app/javascript/mastodon/features/compose/util/counter.js

@@ -1,9 +1,20 @@
+import regexSupplant from 'twitter-text/dist/lib/regexSupplant';
+import validDomain from 'twitter-text/dist/regexp/validDomain';
+
 import { urlRegex } from './url_regex';
 
 const urlPlaceholder = '$2xxxxxxxxxxxxxxxxxxxxxxx';
 
+const validMention = regexSupplant(
+  '(^|[^/\\w])@(([a-z0-9_]+)@(#{validDomain}))',
+  {
+    validDomain,
+  },
+  'ig'
+);
+
 export function countableText(inputText) {
   return inputText
     .replace(urlRegex, urlPlaceholder)
-    .replace(/(^|[^/\w])@(([a-z0-9_]+)@[a-z0-9.-]+[a-z0-9]+)/ig, '$1@$3');
+    .replace(validMention, '$1@$3');
 }

app/models/account.rb

@@ -71,7 +71,7 @@ class Account < ApplicationRecord
   INSTANCE_ACTOR_ID = -99
 
   USERNAME_RE   = /[a-z0-9_]+([.-]+[a-z0-9_]+)*/i
-  MENTION_RE    = %r{(?<![=/[:word:]])@((#{USERNAME_RE})(?:@[[:word:]]+([.-]+[[:word:]]+)*)?)}
+  MENTION_RE    = %r{(?<![=/[:word:]])@((#{USERNAME_RE})(?:@#{Twitter::TwitterText::Regex[:valid_domain]})?)}
   URL_PREFIX_RE = %r{\Ahttp(s?)://[^/]+}
   USERNAME_ONLY_RE = /\A#{USERNAME_RE}\z/i
   USERNAME_LENGTH_LIMIT = 30

spec/models/account_spec.rb

@@ -401,6 +401,10 @@ RSpec.describe Account do
       expect(subject.match('@alice@example.com')[1]).to eq 'alice@example.com'
     end
 
+    it 'matches full usernames with unicode domain names' do
+      expect(subject.match('@alice@🌈🌈🌈.st')[1]).to eq 'alice@🌈🌈🌈.st'
+    end
+
     it 'matches full usernames with a dot at the end' do
       expect(subject.match('Hello @alice@example.com.')[1]).to eq 'alice@example.com'
     end