Merge 3c2852daf3 into 7273f6c03c

app/controllers/auth/omniauth_callbacks_controller.rb

@@ -38,7 +38,8 @@ class Auth::OmniauthCallbacksController < Devise::OmniauthCallbacksController
   private
 
   def record_login_activity
-    @user.login_activities.create(
+    LoginActivity.create(
+      user: @user,
       success: true,
       authentication_method: :omniauth,
       provider: @provider,

app/controllers/auth/sessions_controller.rb

@@ -151,11 +151,12 @@ class Auth::SessionsController < Devise::SessionsController
     sign_in(user)
     flash.delete(:notice)
 
-    user.login_activities.create(
+    LoginActivity.create(
-      request_details.merge(
+      user: user,
-        authentication_method: security_measure,
+      success: true,
-        success: true
+      authentication_method: security_measure,
-      )
+      ip: request.remote_ip,
+      user_agent: request.user_agent
     )
 
     UserMailer.suspicious_sign_in(user, request.remote_ip, request.user_agent, Time.now.utc).deliver_later! if @login_is_suspicious
@@ -166,12 +167,13 @@ class Auth::SessionsController < Devise::SessionsController
   end
 
   def on_authentication_failure(user, security_measure, failure_reason)
-    user.login_activities.create(
+    LoginActivity.create(
-      request_details.merge(
+      user: user,
-        authentication_method: security_measure,
+      success: false,
-        failure_reason: failure_reason,
+      authentication_method: security_measure,
-        success: false
+      failure_reason: failure_reason,
-      )
+      ip: request.remote_ip,
+      user_agent: request.user_agent
     )
 
     # Only send a notification email every hour at most
@@ -180,13 +182,6 @@ class Auth::SessionsController < Devise::SessionsController
     UserMailer.failed_2fa(user, request.remote_ip, request.user_agent, Time.now.utc).deliver_later!
   end
 
-  def request_details
-    {
-      ip: request.remote_ip,
-      user_agent: request.user_agent,
-    }
-  end
-
   def second_factor_attempts_key(user)
     "2fa_auth_attempts:#{user.id}:#{Time.now.utc.hour}"
   end

app/controllers/settings/login_activities_controller.rb

@@ -5,6 +5,6 @@ class Settings::LoginActivitiesController < Settings::BaseController
   skip_before_action :require_functional!
 
   def index
-    @login_activities = current_user.login_activities.order(id: :desc).page(params[:page])
+    @login_activities = LoginActivity.where(user: current_user).order(id: :desc).page(params[:page])
   end
 end

app/models/custom_filter_status.rb

@@ -17,14 +17,12 @@ class CustomFilterStatus < ApplicationRecord
   belongs_to :custom_filter
   belongs_to :status
 
-  validates :status_id, uniqueness: { scope: :custom_filter_id }
+  validates :status, uniqueness: { scope: :custom_filter }
-  validate :validate_status_access, if: [:custom_filter_account, :status]
+  validate :validate_status_access
-
-  delegate :account, to: :custom_filter, prefix: true, allow_nil: true
 
   private
 
   def validate_status_access
-    errors.add(:status_id, :invalid) unless StatusPolicy.new(custom_filter_account, status).show?
+    errors.add(:status_id, :invalid) unless StatusPolicy.new(custom_filter.account, status).show?
   end
 end

app/models/follow_recommendation_mute.rb

@@ -14,7 +14,7 @@ class FollowRecommendationMute < ApplicationRecord
   belongs_to :account
   belongs_to :target_account, class_name: 'Account'
 
-  validates :target_account_id, uniqueness: { scope: :account_id }
+  validates :target_account, uniqueness: { scope: :account_id }
 
   after_commit :invalidate_follow_recommendations_cache
 

app/models/user.rb

@@ -90,7 +90,6 @@ class User < ApplicationRecord
   has_many :applications, class_name: 'Doorkeeper::Application', as: :owner, dependent: nil
   has_many :backups, inverse_of: :user, dependent: nil
   has_many :invites, inverse_of: :user, dependent: nil
-  has_many :login_activities, inverse_of: :user, dependent: :destroy
   has_many :markers, inverse_of: :user, dependent: :destroy
   has_many :webauthn_credentials, dependent: :destroy
   has_many :ips, class_name: 'UserIp', inverse_of: :user, dependent: nil

spec/controllers/auth/sessions_controller_spec.rb

@@ -100,14 +100,11 @@ RSpec.describe Auth::SessionsController do
       let(:user) { Fabricate(:user, email: 'foo@bar.com', password: 'abcdefgh') }
 
       context 'when using a valid password' do
-        subject do
+        before do
           post :create, params: { user: { email: user.email, password: user.password } }
         end
 
         it 'redirects to home and logs the user in' do
-          expect { subject }
-            .to change(user.login_activities.where(success: true), :count).by(1)
-
           expect(response).to redirect_to(root_path)
 
           expect(controller.current_user).to eq user
@@ -268,9 +265,10 @@ RSpec.describe Auth::SessionsController do
 
           it 'does not log the user in, sets a flash message, and sends a suspicious sign in email', :inline_jobs do
             emails = capture_emails do
-              expect { process_maximum_two_factor_attempts }
+              Auth::SessionsController::MAX_2FA_ATTEMPTS_PER_HOUR.times do
-                .to change(user.login_activities.where(success: false), :count).by(1)
+                post :create, params: { user: { otp_attempt: '1234' } }, session: { attempt_user_id: user.id, attempt_user_updated_at: user.updated_at.to_s }
-
+                expect(controller.current_user).to be_nil
+              end
               post :create, params: { user: { otp_attempt: user.current_otp } }, session: { attempt_user_id: user.id, attempt_user_updated_at: user.updated_at.to_s }
             end
 
@@ -288,13 +286,6 @@ RSpec.describe Auth::SessionsController do
                 subject: eq(I18n.t('user_mailer.failed_2fa.subject'))
               )
           end
-
-          def process_maximum_two_factor_attempts
-            Auth::SessionsController::MAX_2FA_ATTEMPTS_PER_HOUR.times do
-              post :create, params: { user: { otp_attempt: '1234' } }, session: { attempt_user_id: user.id, attempt_user_updated_at: user.updated_at.to_s }
-              expect(controller.current_user).to be_nil
-            end
-          end
         end
 
         context 'when using a valid OTP' do

spec/models/custom_filter_status_spec.rb

@@ -1,33 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe CustomFilterStatus do
-  describe 'Associations' do
-    it { is_expected.to belong_to(:custom_filter) }
-    it { is_expected.to belong_to(:status) }
-  end
-
-  describe 'Validations' do
-    subject { Fabricate.build :custom_filter_status }
-
-    it { is_expected.to validate_uniqueness_of(:status_id).scoped_to(:custom_filter_id) }
-
-    describe 'Status access' do
-      subject { Fabricate.build :custom_filter_status, custom_filter:, status: }
-
-      let(:custom_filter) { Fabricate :custom_filter }
-      let(:status) { Fabricate :status }
-
-      context 'when policy allows filter account to access status' do
-        it { is_expected.to allow_value(status.id).for(:status_id) }
-      end
-
-      context 'when policy does not allow filter account to access status' do
-        before { status.account.touch(:suspended_at) }
-
-        it { is_expected.to_not allow_value(status.id).for(:status_id) }
-      end
-    end
-  end
-end

spec/models/follow_recommendation_mute_spec.rb

@@ -1,30 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe FollowRecommendationMute do
-  describe 'Associations' do
-    it { is_expected.to belong_to(:account) }
-    it { is_expected.to belong_to(:target_account).class_name('Account') }
-  end
-
-  describe 'Validations' do
-    subject { Fabricate.build :follow_recommendation_mute }
-
-    it { is_expected.to validate_uniqueness_of(:target_account_id).scoped_to(:account_id) }
-  end
-
-  describe 'Callbacks' do
-    describe 'Maintaining the recommendation cache' do
-      let(:account) { Fabricate :account }
-      let(:cache_key) { "follow_recommendations/#{account.id}" }
-
-      before { Rails.cache.write(cache_key, 123) }
-
-      it 'purges on save' do
-        expect { Fabricate :follow_recommendation_mute, account: account }
-          .to(change { Rails.cache.exist?(cache_key) }.from(true).to(false))
-      end
-    end
-  end
-end

spec/models/user_spec.rb

@@ -24,7 +24,6 @@ RSpec.describe User do
 
   describe 'Associations' do
     it { is_expected.to belong_to(:account).required }
-    it { is_expected.to have_many(:login_activities) }
   end
 
   describe 'Validations' do

yarn.lock

@@ -5764,7 +5764,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"chokidar@npm:^3.6.0":
+"chokidar@npm:^3.5.3":
   version: 3.6.0
   resolution: "chokidar@npm:3.6.0"
   dependencies:
@@ -11298,8 +11298,8 @@ __metadata:
   linkType: hard
 
 "react-select@npm:^5.7.3":
-  version: 5.10.2
+  version: 5.10.1
-  resolution: "react-select@npm:5.10.2"
+  resolution: "react-select@npm:5.10.1"
   dependencies:
     "@babel/runtime": "npm:^7.12.0"
     "@emotion/cache": "npm:^11.4.0"
@@ -11313,7 +11313,7 @@ __metadata:
   peerDependencies:
     react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
     react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
-  checksum: 10c0/2027ef57b0a375d1accdad60550329dc0911b31d429ec6eb9ae391ae9baf9f26991b0ff8615eb99de319a55ce6e9382107783e615cb2116522ed0275b214b7f7
+  checksum: 10c0/0d10a249b96150bd648f2575d59c848b8fac7f4d368a97ae84e4aaba5bbc1035deba4cdc82e49a43904b79ec50494505809618b0e98022b2d51e7629551912ed
   languageName: node
   linkType: hard
 
@@ -13904,17 +13904,17 @@ __metadata:
   linkType: hard
 
 "vite-plugin-static-copy@npm:^3.1.0":
-  version: 3.1.1
+  version: 3.1.0
-  resolution: "vite-plugin-static-copy@npm:3.1.1"
+  resolution: "vite-plugin-static-copy@npm:3.1.0"
   dependencies:
-    chokidar: "npm:^3.6.0"
+    chokidar: "npm:^3.5.3"
     fs-extra: "npm:^11.3.0"
     p-map: "npm:^7.0.3"
     picocolors: "npm:^1.1.1"
     tinyglobby: "npm:^0.2.14"
   peerDependencies:
     vite: ^5.0.0 || ^6.0.0 || ^7.0.0
-  checksum: 10c0/a4dd5d31212b037d4902d55c2ee83866e496857bf948f258599dc24ec61b4628cf0dd23e4a7d7dc189d33ad1489427e976fa95e4db61b394d0be4f63077ef92c
+  checksum: 10c0/dce43f12ecc71417f1afd530d15b316774fe0441c2502e48e2bfafcd07fd4ae90a5782621f932d8d12a8c8213bed6746e80d5452e2fb216ece2bcf7e80309f82
   languageName: node
   linkType: hard