Compare commits

...

6 Commits

Author SHA1 Message Date
Thomas Steiner
57f03145a9
Merge f2a151805f into 74fc4dbacf 2025-07-15 17:05:58 +00:00
diondiondion
74fc4dbacf
refactor: Only remove pointer-events when necessary (#35390)
Some checks failed
Check i18n / check-i18n (push) Waiting to run
Chromatic / Run Chromatic (push) Waiting to run
CodeQL / Analyze (javascript) (push) Waiting to run
CodeQL / Analyze (ruby) (push) Waiting to run
Check formatting / lint (push) Waiting to run
CSS Linting / lint (push) Waiting to run
Ruby Testing / build (production) (push) Waiting to run
Ruby Testing / build (test) (push) Waiting to run
Ruby Testing / test (.ruby-version) (push) Blocked by required conditions
Ruby Testing / test (3.2) (push) Blocked by required conditions
Ruby Testing / test (3.3) (push) Blocked by required conditions
Ruby Testing / ImageMagick tests (.ruby-version) (push) Blocked by required conditions
Ruby Testing / ImageMagick tests (3.2) (push) Blocked by required conditions
Ruby Testing / ImageMagick tests (3.3) (push) Blocked by required conditions
Ruby Testing / End to End testing (.ruby-version) (push) Blocked by required conditions
Ruby Testing / End to End testing (3.2) (push) Blocked by required conditions
Ruby Testing / End to End testing (3.3) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (.ruby-version, docker.elastic.co/elasticsearch/elasticsearch:7.17.13) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (.ruby-version, docker.elastic.co/elasticsearch/elasticsearch:8.10.2) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (.ruby-version, opensearchproject/opensearch:2) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (3.2, docker.elastic.co/elasticsearch/elasticsearch:7.17.13) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (3.3, docker.elastic.co/elasticsearch/elasticsearch:7.17.13) (push) Blocked by required conditions
Crowdin / Upload translations / upload-translations (push) Has been cancelled
Haml Linting / lint (push) Has been cancelled
Ruby Linting / lint (push) Has been cancelled
Historical data migration test / test (14-alpine) (push) Has been cancelled
Historical data migration test / test (15-alpine) (push) Has been cancelled
Historical data migration test / test (16-alpine) (push) Has been cancelled
Historical data migration test / test (17-alpine) (push) Has been cancelled
2025-07-15 15:57:31 +00:00
Thomas Steiner
f2a151805f
Merge branch 'mastodon:main' into translate-toots 2025-07-14 13:43:44 +02:00
Thomas Steiner
46e3c18071 Make supported translate language detection dynamic 2025-06-30 11:10:27 +02:00
Thomas Steiner
6c38ab5b6b Make translate undo work 2025-06-22 13:14:45 +02:00
Thomas Steiner
5e50840986 Translation works, undo still doesn't 2025-06-22 12:54:42 +02:00
2 changed files with 74 additions and 13 deletions

View File

@ -10,6 +10,8 @@ import ImmutablePropTypes from 'react-immutable-proptypes';
import { connect } from 'react-redux';
import ChevronRightIcon from '@/material-icons/400-24px/chevron_right.svg?react';
import { translateStatusSuccess } from 'mastodon/actions/statuses';
import { undoStatusTranslation } from 'mastodon/actions/statuses';
import { Icon } from 'mastodon/components/icon';
import { Poll } from 'mastodon/components/poll';
import { identityContextPropShape, withIdentity } from 'mastodon/identity_context';
@ -17,6 +19,8 @@ import { autoPlayGif, languages as preloadedLanguages } from 'mastodon/initial_s
const MAX_HEIGHT = 706; // 22px * 32 (+ 2px padding at the top)
const supportsTranslator = 'Translator' in globalThis;
/**
*
* @param {any} status
@ -64,10 +68,18 @@ class TranslateButton extends PureComponent {
}
const mapStateToProps = state => ({
languages: state.getIn(['server', 'translationLanguages', 'items']),
languages: supportsTranslator ? new Map() : state.getIn(['server', 'translationLanguages', 'items']),
});
class StatusContent extends PureComponent {
constructor(props) {
super(props);
this.state = {
showTranslateButton: false,
};
}
static propTypes = {
identity: identityContextPropShape,
status: ImmutablePropTypes.map.isRequired,
@ -161,8 +173,34 @@ class StatusContent extends PureComponent {
}
};
componentDidMount () {
async componentDidMount () {
this._updateStatusLinks();
const { status, intl, languages } = this.props;
const contentLocale = intl.locale.replace(/[_-].*/, '');
const targetLanguages = languages?.get(status.get('language') || 'und');
const shouldAttemptTranslate =
this.props.onTranslate &&
this.props.identity.signedIn &&
['public', 'unlisted'].includes(status.get('visibility')) &&
status.get('search_index').trim().length > 0;
if (!shouldAttemptTranslate) return;
let available = false;
if (supportsTranslator) {
available = (await Translator.availability({
sourceLanguage: status.get('language'),
targetLanguage: contentLocale,
})) !== 'unavailable';
} else {
available = targetLanguages?.includes(contentLocale);
}
if (available) {
this.setState({ showTranslateButton: true });
}
}
componentDidUpdate () {
@ -212,8 +250,37 @@ class StatusContent extends PureComponent {
this.startXY = null;
};
handleTranslate = () => {
handleTranslate = async () => {
if (!supportsTranslator) {
this.props.onTranslate();
return;
}
const { intl, status, statusContent } = this.props;
if (status.get('translation')) {
this.props.dispatch(undoStatusTranslation(status.get('id'), status.get('poll')));
return;
}
const sourceLanguage = status.get('language');
const targetLanguage = intl.locale.replace(/[_-].*/, '');
try {
const translator = await Translator.create({
sourceLanguage,
targetLanguage,
});
const translatedText = await translator.translate(statusContent);
const translation = {
content: translatedText,
provider: 'Translator API',
detected_source_language: sourceLanguage,
language: targetLanguage,
};
this.props.dispatch(translateStatusSuccess(status.get('id'), translation));
} catch (error) {
console.error(error);
}
};
setRef = (c) => {
@ -221,12 +288,9 @@ class StatusContent extends PureComponent {
};
render () {
const { status, intl, statusContent } = this.props;
const { status, statusContent } = this.props;
const renderReadMore = this.props.onClick && status.get('collapsed');
const contentLocale = intl.locale.replace(/[_-].*/, '');
const targetLanguages = this.props.languages?.get(status.get('language') || 'und');
const renderTranslate = this.props.onTranslate && this.props.identity.signedIn && ['public', 'unlisted'].includes(status.get('visibility')) && status.get('search_index').trim().length > 0 && targetLanguages?.includes(contentLocale);
const content = { __html: statusContent ?? getStatusContent(status) };
const language = status.getIn(['translation', 'language']) || status.get('language');
@ -241,7 +305,7 @@ class StatusContent extends PureComponent {
</button>
);
const translateButton = renderTranslate && (
const translateButton = this.state.showTranslateButton && (
<TranslateButton onClick={this.handleTranslate} translation={status.get('translation')} />
);
@ -272,8 +336,7 @@ class StatusContent extends PureComponent {
</div>
);
}
}
};
}
export default withRouter(withIdentity(connect(mapStateToProps)(injectIntl(StatusContent))));

View File

@ -2848,7 +2848,6 @@ a.account__display-name {
&__pane {
height: 100%;
overflow: hidden;
pointer-events: none;
display: flex;
justify-content: flex-end;
min-width: 285px;
@ -2860,7 +2859,6 @@ a.account__display-name {
&__inner {
position: fixed;
width: 285px;
pointer-events: auto;
height: 100%;
}
}