Merge e2a56efa9e into c442589593

app/controllers/api/base_controller.rb

@@ -92,7 +92,7 @@ class Api::BaseController < ApplicationController
   end
 
   def disallow_unauthenticated_api_access?
-    ENV['DISALLOW_UNAUTHENTICATED_API_ACCESS'] == 'true' || Rails.configuration.x.mastodon.limited_federation_mode
+    Rails.configuration.x.mastodon.disallow_unauthenticated_api_access || Rails.configuration.x.mastodon.limited_federation_mode
   end
 
   private

app/serializers/webfinger_serializer.rb

@@ -30,12 +30,15 @@ class WebfingerSerializer < ActiveModel::Serializer
   private
 
   def show_avatar?
-    media_present = object.avatar.present? && object.avatar.content_type.present?
+    media_present? && config_allows_public_access?
+  end
 
-    # Show avatar only if an instance shows profiles to logged out users
+  def media_present?
-    allowed_by_config = ENV['DISALLOW_UNAUTHENTICATED_API_ACCESS'] != 'true' && !Rails.configuration.x.mastodon.limited_federation_mode
+    object.avatar.present? && object.avatar.content_type.present?
+  end
 
-    media_present && allowed_by_config
+  def config_allows_public_access?
+    !Rails.configuration.x.mastodon.disallow_unauthenticated_api_access && !Rails.configuration.x.mastodon.limited_federation_mode
   end
 
   def profile_page_href

config/mastodon.yml

@@ -1,5 +1,6 @@
 ---
 shared:
+  disallow_unauthenticated_api_access: <%= ENV.fetch('DISALLOW_UNAUTHENTICATED_API_ACCESS', nil) == 'true' %>
   experimental_features: <%= ENV.fetch('EXPERIMENTAL_FEATURES', nil) %>
   limited_federation_mode: <%= (ENV.fetch('LIMITED_FEDERATION_MODE', nil) || ENV.fetch('WHITELIST_MODE', nil)) == 'true' %>
   self_destruct_value: <%= ENV.fetch('SELF_DESTRUCT', nil)&.to_json %>

spec/requests/cache_spec.rb

@@ -555,9 +555,10 @@ RSpec.describe 'Caching behavior' do
 
   context 'when enabling DISALLOW_UNAUTHENTICATED_API_ACCESS' do
     around do |example|
-      ClimateControl.modify DISALLOW_UNAUTHENTICATED_API_ACCESS: 'true' do
+      original = Rails.configuration.x.mastodon.disallow_unauthenticated_api_access
-        example.run
+      Rails.configuration.x.mastodon.disallow_unauthenticated_api_access = true
-      end
+      example.run
+      Rails.configuration.x.mastodon.disallow_unauthenticated_api_access = original
     end
 
     context 'when anonymously accessed' do

spec/requests/well_known/webfinger_spec.rb

@@ -189,9 +189,10 @@ RSpec.describe 'The /.well-known/webfinger endpoint' do
 
     context 'when enabling DISALLOW_UNAUTHENTICATED_API_ACCESS' do
       around do |example|
-        ClimateControl.modify DISALLOW_UNAUTHENTICATED_API_ACCESS: 'true' do
+        original = Rails.configuration.x.mastodon.disallow_unauthenticated_api_access
-          example.run
+        Rails.configuration.x.mastodon.disallow_unauthenticated_api_access = true
-        end
+        example.run
+        Rails.configuration.x.mastodon.disallow_unauthenticated_api_access = original
       end
 
       it 'does not return avatar in response' do