From 440f327bade2f3a75b2e138ab5ae83fb0c8d8f27 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 14 Apr 2020 20:00:53 +0200
Subject: [PATCH 1/3] minor layout improvements

---
 views/bootstrap/class.Bootstrap.php    |  2 +-
 views/bootstrap/class.ViewDocument.php | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/views/bootstrap/class.Bootstrap.php b/views/bootstrap/class.Bootstrap.php
index 64e1d031f..91b1c8c60 100644
--- a/views/bootstrap/class.Bootstrap.php
+++ b/views/bootstrap/class.Bootstrap.php
@@ -943,7 +943,7 @@ background-image: linear-gradient(to bottom, #882222, #111111);;
 
 	function formSubmit($value, $name='') { /* {{{ */
 		echo "<div class=\"controls\">\n";
-		echo "<button type=\"submit\" class=\"btn\"".($name ? ' name="'.$name.'" id="'.$name.'"' : '').">".$value."</button>\n";
+		echo "<button type=\"submit\" class=\"btn btn-primary\"".($name ? ' name="'.$name.'" id="'.$name.'"' : '').">".$value."</button>\n";
 		echo "</div>\n";
 	} /* }}} */
 
diff --git a/views/bootstrap/class.ViewDocument.php b/views/bootstrap/class.ViewDocument.php
index 34f5c9b3e..67477b0e8 100644
--- a/views/bootstrap/class.ViewDocument.php
+++ b/views/bootstrap/class.ViewDocument.php
@@ -1278,8 +1278,6 @@ class SeedDMS_View_ViewDocument extends SeedDMS_Bootstrap_Style {
 		  <div class="tab-pane <?php if($currenttab == 'attachments') echo 'active'; ?>" id="attachments">
 <?php
 
-		$this->contentContainerStart();
-
 		if (count($files) > 0) {
 
 			print "<table class=\"table\">";
@@ -1350,10 +1348,12 @@ class SeedDMS_View_ViewDocument extends SeedDMS_Bootstrap_Style {
 			print "</tbody>\n</table>\n";	
 
 		}
-		else printMLText("no_attached_files");
+		else $this->infoMsg(getMLText("no_attached_files"));
+
+		$this->contentContainerStart();
 
 		if ($document->getAccessMode($user) >= M_READWRITE){
-			print "<ul class=\"unstyled\"><li><a href=\"../out/out.AddFile.php?documentid=".$documentid."\" class=\"btn\">".getMLText("add")."</a></ul>\n";
+			print "<a href=\"../out/out.AddFile.php?documentid=".$documentid."\" class=\"btn btn-primary\">".getMLText("add")."</a>\n";
 		}
 		$this->contentContainerEnd();
 ?>
@@ -1394,7 +1394,7 @@ class SeedDMS_View_ViewDocument extends SeedDMS_Bootstrap_Style {
 			}
 			print "</tbody>\n</table>\n";
 		}
-		else printMLText("no_linked_files");
+		else $this->infoMsg(getMLText("no_linked_files"));
 
 		if (!$user->isGuest()){
 			$this->contentContainerStart();

From 2d5a4d5bd44b18724cbafa11cfa866b31dd34c5d Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Thu, 16 Apr 2020 15:54:37 +0200
Subject: [PATCH 2/3] list only user in session which are not hidden

---
 views/bootstrap/class.Session.php | 36 +++++++++++++++++++++----------
 1 file changed, 25 insertions(+), 11 deletions(-)

diff --git a/views/bootstrap/class.Session.php b/views/bootstrap/class.Session.php
index d844eefd3..ed477034c 100644
--- a/views/bootstrap/class.Session.php
+++ b/views/bootstrap/class.Session.php
@@ -52,20 +52,34 @@ class SeedDMS_View_Session extends SeedDMS_Bootstrap_Style {
 		if ($user->isGuest() || count($sessions) == 0) {
 			return '';
 		}
-		$content = '';
-		$content .= "   <ul id=\"main-menu-session\" class=\"nav pull-right\">\n";
-		$content .= "    <li class=\"dropdown add-session-area\">\n";
-		$content .= "     <a href=\"#\" class=\"dropdown-toggle\" data-toggle=\"dropdown\" class=\"add-session-area\">".getMLText('sessions')." (".count($sessions).") <i class=\"icon-caret-down\"></i></a>\n";
-		$content .= "     <ul class=\"dropdown-menu\" role=\"menu\">\n";
+
+		/* $hasuser will be set to true when at least one of the logged in users
+		 * is visible and not hidden in user lists.
+		 */
+		$c = 0;
+		$ucontent = '';
 		foreach($sessions as $session) {
 			if($sesuser = $dms->getUser($session->getUser()))
-				if(!$sesuser->isHidden())
-					$content .= "    <li><a _href=\"\"><i class=\"icon-user\"></i> ".htmlspecialchars($sesuser->getFullName())." ".getReadableDuration(time()-$session->getLastAccess())."</a></li>\n";
+				if(!$sesuser->isHidden()) {
+					$c++;
+					$hasuser = true;
+					$ucontent .= "    <li><a _href=\"\"><i class=\"icon-user\"></i> ".htmlspecialchars($sesuser->getFullName())." ".getReadableDuration(time()-$session->getLastAccess())."</a></li>\n";
+				}
+		}
+		if($c) {
+			$content = '';
+			$content .= "   <ul id=\"main-menu-session\" class=\"nav pull-right\">\n";
+			$content .= "    <li class=\"dropdown add-session-area\">\n";
+			$content .= "     <a href=\"#\" class=\"dropdown-toggle\" data-toggle=\"dropdown\" class=\"add-session-area\">".getMLText('sessions')." (".$c.") <i class=\"icon-caret-down\"></i></a>\n";
+			$content .= "     <ul class=\"dropdown-menu\" role=\"menu\">\n";
+			$content .= $ucontent;
+			$content .= "     </ul>\n";
+			$content .= "    </li>\n";
+			$content .= "   </ul>\n";
+			echo $content;
+		} else {
+			return '';
 		}
-		$content .= "     </ul>\n";
-		$content .= "    </li>\n";
-		$content .= "   </ul>\n";
-		echo $content;
 	} /* }}} */
 
 }

From 3929d650e50c5a03c3a929dfb94ad7cdd853eb48 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Thu, 16 Apr 2020 15:55:27 +0200
Subject: [PATCH 3/3] changes for 5.1.16

---
 CHANGELOG | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG b/CHANGELOG
index 06ff3b6e3..85a45a6aa 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -7,6 +7,7 @@
 - allow multiple dependencies on seeddms of extension
 - add table with chart data below chart
 - do now show tasks in menu if workflow is turned off completely
+- do not show hidden users in session list
 
 --------------------------------------------------------------------------------
                      Changes in version 5.1.15