Merge branch 'seeddms-4.3.x' into seeddms-5.0.x

CHANGELOG

@@ -3,6 +3,9 @@
 --------------------------------------------------------------------------------
 - send notification if document is delete to those users watching the folder
 - fix editing of customer attributes of type checkbox
+- disallow read access for group didn't prevent the users from being selected
+  as a reviewer/approver
+- move the last bits of plain sql code from op/*.php into the core
 
 --------------------------------------------------------------------------------
                      Changes in version 4.3.22

op/op.CreateDump.php

@@ -16,6 +16,7 @@
 //    along with this program; if not, write to the Free Software
 //    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
+include("../inc/inc.Version.php");
 include("../inc/inc.Settings.php");
 include("../inc/inc.LogInit.php");
 include("../inc/inc.Language.php");
@@ -29,7 +30,8 @@ if (!$user->isAdmin()) {
 	UI::exitError(getMLText("admin_tools"),getMLText("access_denied"));
 }
 
-$dump_name = $settings->_contentDir.time().".sql";
+$v = new SeedDMS_Version;
+$dump_name = $settings->_contentDir.date('Y-m-d\TH:i:s')."_".$v->_number.".sql";
 if(!$dms->createDump($dump_name))
 	UI::exitError(getMLText("admin_tools"),getMLText("error_occured"));
 

op/op.RemoveVersion.php

@@ -113,6 +113,7 @@ else {
 	 */
 	$emailUserList = array();
 	$emailUserList[] = $version->_userID;
+	$emailGroupList = array();
 	$status = $version->getReviewStatus();
 	foreach ($status as $st) {
 		if ($st["status"]==0 && !in_array($st["required"], $emailUserList)) {