simplified removeDocumentCategory

This commit is contained in:
Uwe Steinmann 2023-12-13 08:23:58 +01:00
parent cab5f5bb2e
commit 1ac232476a

View File

@ -1562,24 +1562,20 @@ class RestapiController { /* {{{ */
} }
$document = $dms->getDocument($args['id']); $document = $dms->getDocument($args['id']);
if(!$document)
return $response->withJson(array('success'=>false, 'message'=>'No such document', 'data'=>''), 404);
$category = $dms->getDocumentCategory($args['catid']); $category = $dms->getDocumentCategory($args['catid']);
if(!$category)
return $response->withJson(array('success'=>false, 'message'=>'No such category', 'data'=>''), 404);
if($document && $category) { if ($document->getAccessMode($userobj, 'removeDocumentCategory') >= M_READWRITE) {
if ($document->getAccessMode($userobj, 'removeDocumentCategory') >= M_READWRITE) { $ret = $document->removeCategories(array($category));
$ret = $document->removeCategories(array($category)); if ($ret)
if ($ret) return $response->withJson(array('success'=>true, 'message'=>'Deleted category successfully.', 'data'=>''), 200);
return $response->withJson(array('success'=>true, 'message'=>'Deleted category successfully.', 'data'=>''), 200); else
else return $response->withJson(array('success'=>true, 'message'=>'', 'data'=>''), 200);
return $response->withJson(array('success'=>true, 'message'=>'', 'data'=>''), 200);
} else {
return $response->withJson(array('success'=>false, 'message'=>'No access', 'data'=>''), 403);
}
} else { } else {
if(!$document) return $response->withJson(array('success'=>false, 'message'=>'No access', 'data'=>''), 403);
return $response->withJson(array('success'=>false, 'message'=>'No such document', 'data'=>''), 404);
if(!$category)
return $response->withJson(array('success'=>false, 'message'=>'No such category', 'data'=>''), 404);
return $response->withJson(array('success'=>false, 'message'=>'', 'data'=>''), 500);
} }
} /* }}} */ } /* }}} */