From 3a47861a500004f6c94594d5f273ffc6fa955218 Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Mon, 15 Feb 2016 08:04:38 +0100 Subject: [PATCH] propperly returns false if operation fails in addGroup() and delGroup() --- SeedDMS_Core/Core/inc.ClassGroup.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SeedDMS_Core/Core/inc.ClassGroup.php b/SeedDMS_Core/Core/inc.ClassGroup.php index 762a59fb8..f6f61d327 100644 --- a/SeedDMS_Core/Core/inc.ClassGroup.php +++ b/SeedDMS_Core/Core/inc.ClassGroup.php @@ -128,7 +128,7 @@ class SeedDMS_Core_Group { $queryStr = "INSERT INTO tblGroupMembers (groupID, userID, manager) VALUES (".$this->_id.", ".$user->getID(). ", " . ($asManager?"1":"0") ." )"; $res = $db->getResult($queryStr); - if ($res) return false; + if (!$res) return false; unset($this->_users); return true; @@ -140,7 +140,7 @@ class SeedDMS_Core_Group { $queryStr = "DELETE FROM tblGroupMembers WHERE groupID = ".$this->_id." AND userID = ".$user->getID(); $res = $db->getResult($queryStr); - if ($res) return false; + if (!$res) return false; unset($this->_users); return true; } /* }}} */