From 4e1e126783a7f53459aece1e371fccab61b9f2ee Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Mon, 21 Nov 2022 16:32:06 +0100 Subject: [PATCH] propperly rollback addDocument() if add categories fails --- SeedDMS_Core/Core/inc.ClassFolder.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/SeedDMS_Core/Core/inc.ClassFolder.php b/SeedDMS_Core/Core/inc.ClassFolder.php index 23324676f..59ab9b811 100644 --- a/SeedDMS_Core/Core/inc.ClassFolder.php +++ b/SeedDMS_Core/Core/inc.ClassFolder.php @@ -1059,7 +1059,11 @@ class SeedDMS_Core_Folder extends SeedDMS_Core_Object { } if($categories) { - $document->setCategories($categories); + if(!$document->setCategories($categories)) { + $document->remove(); + $db->rollbackTransaction(); + return false; + } } if($attributes) {