gnh1201/seeddms-code
1
0
Fork 0
mirror of https://git.code.sf.net/p/seeddms/code synced 2025-05-12 20:51:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

check for new return values when modifying reviewers and approvers

Browse Source
This commit is contained in:
Uwe Steinmann 2021-09-29 17:27:43 +02:00
parent 6d92be55fb
commit 529efd6baa
1 changed files with 48 additions and 64 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
op/op.SetReviewersApprovers.php
View File

@ -127,8 +127,8 @@ foreach ($pIndRev as $p) {
// Proposed reviewer is not a current reviewer, so add as a new // Proposed reviewer is not a current reviewer, so add as a new
// reviewer. // reviewer.
$res = $content->addIndReviewer($docAccess["users"][$accessIndex["i"][$p]], $user); $res = $content->addIndReviewer($docAccess["users"][$accessIndex["i"][$p]], $user);
switch ($res) { switch (true) {
case 0: case $res > 0:
// Send an email notification to the new reviewer. // Send an email notification to the new reviewer.
if($settings->_enableNotificationAppRev) { if($settings->_enableNotificationAppRev) {
if ($notifier) { if ($notifier) {
@ -136,18 +136,16 @@ foreach ($pIndRev as $p) {
} }
} }
break; break;
case -1: case $res === -1:
case $res === false:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error"));
break; break;
case -2: case $res === -2:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied"));
break; break;
case -3: case $res === -3:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_assigned")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_assigned"));
break; break;
case -4:
// email error
break;
} }
} }
else { else {
@ -181,8 +179,8 @@ if (count($reviewIndex["i"]) > 0) {
} }
else { else {
$res = $content->delIndReviewer($docAccess["users"][$accessIndex["i"][$rx]], $user); $res = $content->delIndReviewer($docAccess["users"][$accessIndex["i"][$rx]], $user);
switch ($res) { switch (true) {
case 0: case $res === 0:
// Send an email notification to the reviewer. // Send an email notification to the reviewer.
if($settings->_enableNotificationAppRev) { if($settings->_enableNotificationAppRev) {
if ($notifier) { if ($notifier) {
@ -190,18 +188,16 @@ if (count($reviewIndex["i"]) > 0) {
} }
} }
break; break;
case -1: case $res === -1:
case $res === false:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error"));
break; break;
case -2: case $res === -2:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied"));
break; break;
case -3: case $res === -3:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_removed")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_removed"));
break; break;
case -4:
// email error
break;
} }
} }
} }
@ -215,8 +211,8 @@ foreach ($pGrpRev as $p) {
// Proposed reviewer is not a current reviewer, so add as a new // Proposed reviewer is not a current reviewer, so add as a new
// reviewer. // reviewer.
$res = $content->addGrpReviewer($docAccess["groups"][$accessIndex["g"][$p]], $user); $res = $content->addGrpReviewer($docAccess["groups"][$accessIndex["g"][$p]], $user);
switch ($res) { switch (true) {
case 0: case $res > 0:
// Send an email notification to the new reviewer. // Send an email notification to the new reviewer.
if($settings->_enableNotificationAppRev) { if($settings->_enableNotificationAppRev) {
if ($notifier) { if ($notifier) {
@ -224,18 +220,16 @@ foreach ($pGrpRev as $p) {
} }
} }
break; break;
case -1: case $res === -1:
case $res === false:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error"));
break; break;
case -2: case $res === -2:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied"));
break; break;
case -3: case $res === -3:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_assigned")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_assigned"));
break; break;
case -4:
// email error
break;
} }
} }
else { else {
@ -261,8 +255,8 @@ if (count($reviewIndex["g"]) > 0) {
} }
else { else {
$res = $content->delGrpReviewer($docAccess["groups"][$accessIndex["g"][$rx]], $user); $res = $content->delGrpReviewer($docAccess["groups"][$accessIndex["g"][$rx]], $user);
switch ($res) { switch (true) {
case 0: case $res === 0:
// Send an email notification to the review group. // Send an email notification to the review group.
if($settings->_enableNotificationAppRev) { if($settings->_enableNotificationAppRev) {
if ($notifier) { if ($notifier) {
@ -270,18 +264,16 @@ if (count($reviewIndex["g"]) > 0) {
} }
} }
break; break;
case -1: case $res === -1:
case $res === false:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error"));
break; break;
case -2: case $res === -2:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied"));
break; break;
case -3: case $res === -3:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_removed")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_removed"));
break; break;
case -4:
// email error
break;
} }
} }
} }
@ -311,8 +303,8 @@ foreach ($pIndApp as $p) {
// Proposed approver is not a current approver, so add as a new // Proposed approver is not a current approver, so add as a new
// approver. // approver.
$res = $content->addIndApprover($docAccess["users"][$accessIndex["i"][$p]], $user); $res = $content->addIndApprover($docAccess["users"][$accessIndex["i"][$p]], $user);
switch ($res) { switch (true) {
case 0: case $res > 0:
// Send an email notification to the new approver. // Send an email notification to the new approver.
if($settings->_enableNotificationAppRev) { if($settings->_enableNotificationAppRev) {
/* Send notification only if document is currently not in review state, /* Send notification only if document is currently not in review state,
@ -324,18 +316,16 @@ foreach ($pIndApp as $p) {
} }
} }
break; break;
case -1: case $res === -1:
case $res === false:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error"));
break; break;
case -2: case $res === -2:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied"));
break; break;
case -3: case $res === -3:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_assigned")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_assigned"));
break; break;
case -4:
// email error
break;
} }
} }
else { else {
@ -361,8 +351,8 @@ if (count($approvalIndex["i"]) > 0) {
} }
else { else {
$res = $content->delIndApprover($docAccess["users"][$accessIndex["i"][$rx]], $user); $res = $content->delIndApprover($docAccess["users"][$accessIndex["i"][$rx]], $user);
switch ($res) { switch (true) {
case 0: case $res === 0:
// Send an email notification to the approver. // Send an email notification to the approver.
if($settings->_enableNotificationAppRev) { if($settings->_enableNotificationAppRev) {
if ($notifier) { if ($notifier) {
@ -370,18 +360,16 @@ if (count($approvalIndex["i"]) > 0) {
} }
} }
break; break;
case -1: case $res === -1:
case $res === false:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error"));
break; break;
case -2: case $res === -2:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied"));
break; break;
case -3: case $res === -3:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_removed")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("reviewer_already_removed"));
break; break;
case -4:
// email error
break;
} }
} }
} }
@ -395,8 +383,8 @@ foreach ($pGrpApp as $p) {
// Proposed approver is not a current approver, so add as a new // Proposed approver is not a current approver, so add as a new
// approver. // approver.
$res = $content->addGrpApprover($docAccess["groups"][$accessIndex["g"][$p]], $user); $res = $content->addGrpApprover($docAccess["groups"][$accessIndex["g"][$p]], $user);
switch ($res) { switch (true) {
case 0: case $res > 0:
// Send an email notification to the new approver. // Send an email notification to the new approver.
if($settings->_enableNotificationAppRev) { if($settings->_enableNotificationAppRev) {
/* Send notification only if document is currently not in review state, /* Send notification only if document is currently not in review state,
@ -408,18 +396,16 @@ foreach ($pGrpApp as $p) {
} }
} }
break; break;
case -1: case $res === -1:
case $res === false:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error"));
break; break;
case -2: case $res === -2:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied"));
break; break;
case -3: case $res === -3:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("approver_already_assigned")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("approver_already_assigned"));
break; break;
case -4:
// email error
break;
} }
} }
else { else {
@ -445,8 +431,8 @@ if (count($approvalIndex["g"]) > 0) {
} }
else { else {
$res = $content->delGrpApprover($docAccess["groups"][$accessIndex["g"][$rx]], $user); $res = $content->delGrpApprover($docAccess["groups"][$accessIndex["g"][$rx]], $user);
switch ($res) { switch (true) {
case 0: case $res === 0:
// Send an email notification to the approval group. // Send an email notification to the approval group.
if($settings->_enableNotificationAppRev) { if($settings->_enableNotificationAppRev) {
if ($notifier) { if ($notifier) {
@ -454,18 +440,16 @@ if (count($approvalIndex["g"]) > 0) {
} }
} }
break; break;
case -1: case $res === -1:
case $res === false:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("internal_error"));
break; break;
case -2: case $res === -2:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("access_denied"));
break; break;
case -3: case $res === -3:
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("approver_already_removed")); UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("approver_already_removed"));
break; break;
case -4:
// email error
break;
} }
} }
} }