From ac22269120137e80a5c6334d7d4e5c2122a884ae Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 2 Dec 2025 13:52:03 +0100
Subject: [PATCH 1/6] add button to password fields for toggling visibility

---
 views/bootstrap/class.Bootstrap.php   |  2 +-
 views/bootstrap/styles/application.js | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/views/bootstrap/class.Bootstrap.php b/views/bootstrap/class.Bootstrap.php
index f700cd6b5..27a77c3eb 100644
--- a/views/bootstrap/class.Bootstrap.php
+++ b/views/bootstrap/class.Bootstrap.php
@@ -1269,7 +1269,7 @@ background-image: linear-gradient(to bottom, #882222, #111111);;
 					break;
 				default:
 					if(!empty($value['addon']))
-						echo "<span class=\"input-append\">";
+						echo '<span class="input-append'.($value["type"]=='password' ? ' show-hide-password' : '').'">';
 					echo '<input'.
 						(!empty($value['type']) ? ' type="'.$value['type'].'"' : '').
 						(!empty($value['id']) ? ' id="'.$value['id'].'"' : '').
diff --git a/views/bootstrap/styles/application.js b/views/bootstrap/styles/application.js
index 8e0ee517c..8f32d9bf6 100644
--- a/views/bootstrap/styles/application.js
+++ b/views/bootstrap/styles/application.js
@@ -369,6 +369,22 @@ $(document).ready( function() {
 			$($(this).data("target")+' .modal-header h3').html($(this).data("modal-title"));
 	}); /* }}} */
 
+	$('body').on('click', 'span.show-hide-password span', function(ev) { /* {{{ */
+		ev.preventDefault();
+		div = $(this).closest('span.show-hide-password');
+		icon = $(this).children(":first");
+		input = div.children(":first");
+		if (input.attr("type") == "text") {
+			input.attr('type', 'password');
+			icon.addClass( "fa-eye-slash" );
+			icon.removeClass( "fa-eye" );
+		} else if (input.attr("type") == "password") {
+			input.attr('type', 'text');
+			icon.removeClass( "fa-eye-slash" );
+			icon.addClass( "fa-eye" );
+		}
+	}); /* }}} */
+
 	$('body').on('touchstart.dropdown', '.dropdown-menu', function (e) { e.stopPropagation(); });
 
 	initMost();

From a4937e35020ec61d75bb0f446be0a383caf93b2e Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 2 Dec 2025 13:52:45 +0100
Subject: [PATCH 2/6] add button to make password visible

---
 views/bootstrap/class.EditUserData.php | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/views/bootstrap/class.EditUserData.php b/views/bootstrap/class.EditUserData.php
index 2fd2e47d6..cc605ed43 100644
--- a/views/bootstrap/class.EditUserData.php
+++ b/views/bootstrap/class.EditUserData.php
@@ -100,14 +100,26 @@ $(document).ready( function() {
 				'id'=>'currentpwd',
 				'name'=>'currentpwd',
 				'autocomplete'=>'off',
-				'required'=>true
+				'required'=>true,
+				'addon'=>'<i class="fa fa-eye-slash"></i>'
 			)
 		);
 		if(!$disablechangepassword) {
 		$this->formField(
 			getMLText("new_password"),
-			'<input class="form-control pwd" type="password" rel="strengthbar" id="pwd" name="pwd" size="30">'
+			array(
+				'element'=>'input',
+				'type'=>'password',
+				'id'=>'pwd',
+				'name'=>'pwd',
+				'class'=>'pwd',
+				'autocomplete'=>'off',
+				'required'=>true,
+				'attributes'=>[['rel', 'strengthbar']],
+				'addon'=>'<i class="fa fa-eye-slash"></i>'
+			)
 		);
+
 		if($passwordstrength) {
 			$this->formField(
 				getMLText("password_strength"),
@@ -122,6 +134,7 @@ $(document).ready( function() {
 				'id'=>'pwdconf',
 				'name'=>'pwdconf',
 				'autocomplete'=>'off',
+				'addon'=>'<i class="fa fa-eye-slash"></i>'
 			)
 		);
 		}

From 5db0744bf6b616f299dbc5438009a19b2c6a016c Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 2 Dec 2025 13:54:08 +0100
Subject: [PATCH 3/6] use addon for button to make password visible

---
 views/bootstrap/class.Settings.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/views/bootstrap/class.Settings.php b/views/bootstrap/class.Settings.php
index d1829f4e7..a69ebe078 100644
--- a/views/bootstrap/class.Settings.php
+++ b/views/bootstrap/class.Settings.php
@@ -77,8 +77,8 @@ class SeedDMS_View_Settings extends SeedDMS_Theme_Style {
 			$html .= '<div class="input-group'.($type=='password' ? ' show-hide-password' : '').'">';
 			$html .= '<input '.($type=='password' ? 'type="password"' : ($type=='number' ? 'type="number"' : ($type=='color' ? 'type="color"' : 'type="text"'))).' class="form-control '.$class.'" name="'.$name.'" value="'.$value.'" placeholder="'.$placeholder.'"/>';
 			if($this->getTheme() == 'bootstrap4' && $type == 'password') {
-				$html .= '<div class="input-group-addon">';
-				$html .= '<a href=""><i class="fa fa-eye-slash" style="position: absolute; right: 15px; top: 10px;" aria-hidden="true"></i></a>';
+				$html .= '<div class="input-group-append">';
+				$html .= '<span class="input-group-text"><i class="fa fa-eye-slash"></i></span>';
 				$html .= '</div>';
 			}
 			$html .= '</div>';

From e5724e449ab77f9cf7f4b4448626ffd3f5c6ad13 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 2 Dec 2025 13:55:05 +0100
Subject: [PATCH 4/6] add addon to all password fields to make password visible

---
 views/bootstrap4/class.Bootstrap4.php  |  4 ++--
 views/bootstrap4/styles/application.js | 23 ++++++++++++-----------
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/views/bootstrap4/class.Bootstrap4.php b/views/bootstrap4/class.Bootstrap4.php
index f7c948c9f..b2f366967 100644
--- a/views/bootstrap4/class.Bootstrap4.php
+++ b/views/bootstrap4/class.Bootstrap4.php
@@ -1252,12 +1252,12 @@ background-image: linear-gradient(to bottom, #882222, #111111);;
 					break;
 				default:
 					if(!empty($value['addon']))
-						echo '<div class="input-group date">';
+						echo '<div class="input-group date'.($value["type"]=='password' ? ' show-hide-password' : '').'">';
 					echo '<input'.
 						(!empty($value['type']) ? ' type="'.$value['type'].'"' : '').
 						(!empty($value['id']) ? ' id="'.$value['id'].'"' : '').
 						(!empty($value['name']) ? ' name="'.$value['name'].'"' : '').
-						(empty($value['class']) ? ' class="form-control"' : ' class="form-control '.$value['class'].'"').
+						' class="'.(empty($value['class']) ? 'form-control' : 'form-control '.$value['class']).'"'.
 						((isset($value['value']) && is_string($value['value'])) || !empty($value['value']) ? ' value="'.$value['value'].'"' : '').
 						(!empty($value['placeholder']) ? ' placeholder="'.$value['placeholder'].'"' : '').
 						(!empty($value['autocomplete']) ? ' autocomplete="'.$value['autocomplete'].'"' : '').
diff --git a/views/bootstrap4/styles/application.js b/views/bootstrap4/styles/application.js
index c10d6b6ea..e0eb3a029 100644
--- a/views/bootstrap4/styles/application.js
+++ b/views/bootstrap4/styles/application.js
@@ -403,18 +403,19 @@ $(document).ready( function() {
 			$($(this).data("target")+' .modal-header h3').html($(this).data("modal-title"));
 	}); /* }}} */
 
-	$('body').on('click', '.show-hide-password a', function(ev) { /* {{{ */
+	$('body').on('click', 'div.show-hide-password span', function(ev) { /* {{{ */
 		ev.preventDefault();
-//		console.log($(this).closest('input'));
-//		console.log($(ev.target).parent().parent().children('input'));
-		if($('.show-hide-password input').attr("type") == "text"){
-			$('.show-hide-password input').attr('type', 'password');
-			$('.show-hide-password i').addClass( "fa-eye-slash" );
-			$('.show-hide-password i').removeClass( "fa-eye" );
-		}else if($('.show-hide-password input').attr("type") == "password"){
-			$('.show-hide-password input').attr('type', 'text');
-			$('.show-hide-password i').removeClass( "fa-eye-slash" );
-			$('.show-hide-password i').addClass( "fa-eye" );
+		div = $(this).closest('div.show-hide-password');
+		icon = $(this).children(":first");
+		input = div.children(":first");
+		if (input.attr("type") == "text") {
+			input.attr('type', 'password');
+			icon.addClass( "fa-eye-slash" );
+			icon.removeClass( "fa-eye" );
+		} else if (input.attr("type") == "password") {
+			input.attr('type', 'text');
+			icon.removeClass( "fa-eye-slash" );
+			icon.addClass( "fa-eye" );
 		}
 	}); /* }}} */
 

From 621bcab7b5e451af0f6b848a2bdbb5a50aff552d Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 2 Dec 2025 13:55:36 +0100
Subject: [PATCH 5/6] add more changes of 5.1.43

---
 CHANGELOG | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG b/CHANGELOG
index 5d85f2dfa..a816da919 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -14,6 +14,7 @@
 - add javascript table sorter
 - use table sorter on clear cache page and conversion services page
 - droping an url in the drag&drop area will download the url
+- add button to all password fields to make password visible
 
 --------------------------------------------------------------------------------
                      Changes in version 5.1.42

From 282df2a886cd48a4c0a1e5944d6ada9a0ce88e9a Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 2 Dec 2025 21:18:26 +0100
Subject: [PATCH 6/6] fix error msg when migration of extension fails

---
 op/op.ExtensionMgr.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/op/op.ExtensionMgr.php b/op/op.ExtensionMgr.php
index 19a48dc15..9df8b72b6 100644
--- a/op/op.ExtensionMgr.php
+++ b/op/op.ExtensionMgr.php
@@ -160,7 +160,7 @@ elseif ($action == "toggle") { /* {{{ */
 				if($ret === true)
 					echo json_encode(array('success'=>true, 'msg'=>getMLText('extension_migration_success')));
 				else
-					echo json_encode(array('success'=>true, 'msg'=>getMLText('extension_migration_error')));
+					echo json_encode(array('success'=>false, 'msg'=>getMLText('extension_migration_error')));
 			} else {
 				echo json_encode(array('success'=>true, 'msg'=>getMLText('extension_is_on_now')));
 			}