From 6731882ae0b2182474dcbe0a08d60c652b2c0dbe Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Thu, 27 Feb 2025 09:04:55 +0100 Subject: [PATCH] do not add group manager as mandatory reviewer/approver if logged in user is the manager itself --- inc/inc.Utils.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/inc/inc.Utils.php b/inc/inc.Utils.php index d42938604..f2392b35c 100644 --- a/inc/inc.Utils.php +++ b/inc/inc.Utils.php @@ -1075,7 +1075,9 @@ function getMandatoryReviewers($folder, $document, $user) { /* {{{ */ foreach($groups as $group) { $managers = $group->getManagers(); foreach($managers as $manager) { - $revi[] = $manager->getId(); + /* Do not add myself, if I'm the manager of the group */ + if($manager->getId() != $user->getId()) + $revi[] = $manager->getId(); } } } @@ -1170,7 +1172,9 @@ function getMandatoryApprovers($folder, $document, $user) { /* {{{ */ foreach($groups as $group) { $managers = $group->getManagers(); foreach($managers as $manager) { - $appi[] = $manager->getId(); + /* Do not add myself, if I'm the manager of the group */ + if($manager->getId() != $user->getId()) + $appi[] = $manager->getId(); } } }