gnh1201/seeddms-code
1
0
Fork 0
mirror of https://git.code.sf.net/p/seeddms/code synced 2025-05-13 21:21:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

add note in comment about a possible wrong check for a return value

Browse Source
This commit is contained in:
Uwe Steinmann 2021-09-20 16:32:34 +02:00
parent a5e12cb444
commit 69e3ad87f9
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
SeedDMS_Core/Core/inc.ClassDocument.php
View File

@ -1613,6 +1613,7 @@ class SeedDMS_Core_Document extends SeedDMS_Core_Object { /* {{{ */
$docResultSet->addReviewer($reviewer, $i, $res); $docResultSet->addReviewer($reviewer, $i, $res);
// If no error is returned, or if the error is just due to email // If no error is returned, or if the error is just due to email
// failure, mark the state as "pending review". // failure, mark the state as "pending review".
// FIXME: There seems to be no error code -4 anymore
if ($res==0 || $res=-3 || $res=-4) { if ($res==0 || $res=-3 || $res=-4) {
$pendingReview=true; $pendingReview=true;
} }
@ -1629,6 +1630,7 @@ class SeedDMS_Core_Document extends SeedDMS_Core_Object { /* {{{ */
$approver=($i=="i" ? $this->_dms->getUser($approverID) : $this->_dms->getGroup($approverID)); $approver=($i=="i" ? $this->_dms->getUser($approverID) : $this->_dms->getGroup($approverID));
$res=($i=="i" ? $docResultSet->getContent()->addIndApprover($approver, $user, true) : $docResultSet->getContent()->addGrpApprover($approver, $user, !$pendingReview)); $res=($i=="i" ? $docResultSet->getContent()->addIndApprover($approver, $user, true) : $docResultSet->getContent()->addGrpApprover($approver, $user, !$pendingReview));
$docResultSet->addApprover($approver, $i, $res); $docResultSet->addApprover($approver, $i, $res);
// FIXME: There seems to be no error code -4 anymore
if ($res==0 || $res=-3 || $res=-4) { if ($res==0 || $res=-3 || $res=-4) {
$pendingApproval=true; $pendingApproval=true;
} }