do not output timeline if no data is available

This commit is contained in:
Uwe Steinmann 2015-09-22 10:32:33 +02:00
parent 109f814fa9
commit 6a91429711
3 changed files with 37 additions and 31 deletions

View File

@ -2018,6 +2018,8 @@ mayscript>
* @param object $document document * @param object $document document
*/ */
protected function printTimeline($timeline, $height=300, $start='', $end='') { /* {{{ */ protected function printTimeline($timeline, $height=300, $start='', $end='') { /* {{{ */
if(!$timeline)
return;
?> ?>
<script type="text/javascript"> <script type="text/javascript">
var timeline; var timeline;

View File

@ -87,23 +87,25 @@ echo "</div>\n";
echo "<div class=\"span9\">\n"; echo "<div class=\"span9\">\n";
$this->contentHeading(getMLText("timeline")); $this->contentHeading(getMLText("timeline"));
foreach($data as &$item) { if($data) {
switch($item['type']) { foreach($data as &$item) {
case 'add_version': switch($item['type']) {
$msg = getMLText('timeline_full_'.$item['type'], array('document'=>htmlspecialchars($item['document']->getName()), 'version'=> $item['version'])); case 'add_version':
break; $msg = getMLText('timeline_full_'.$item['type'], array('document'=>htmlspecialchars($item['document']->getName()), 'version'=> $item['version']));
case 'add_file': break;
$msg = getMLText('timeline_full_'.$item['type'], array('document'=>htmlspecialchars($item['document']->getName()))); case 'add_file':
break; $msg = getMLText('timeline_full_'.$item['type'], array('document'=>htmlspecialchars($item['document']->getName())));
case 'status_change': break;
$msg = getMLText('timeline_full_'.$item['type'], array('document'=>htmlspecialchars($item['document']->getName()), 'version'=> $item['version'], 'status'=> getOverallStatusText($item['status']))); case 'status_change':
break; $msg = getMLText('timeline_full_'.$item['type'], array('document'=>htmlspecialchars($item['document']->getName()), 'version'=> $item['version'], 'status'=> getOverallStatusText($item['status'])));
default: break;
$msg = '???'; default:
} $msg = '???';
$item['msg'] = $msg;
} }
$this->printTimeline($data, 550, date('Y-m-d', $from), date('Y-m-d', $to+1)); $item['msg'] = $msg;
}
$this->printTimeline($data, 550, date('Y-m-d', $from), date('Y-m-d', $to+1));
}
echo "</div>\n"; echo "</div>\n";
echo "</div>\n"; echo "</div>\n";

View File

@ -1115,23 +1115,25 @@ class SeedDMS_View_ViewDocument extends SeedDMS_Bootstrap_Style {
if($user->isAdmin()) { if($user->isAdmin()) {
$this->contentHeading(getMLText("timeline")); $this->contentHeading(getMLText("timeline"));
$timeline = $document->getTimeline(); $timeline = $document->getTimeline();
foreach($timeline as &$item) { if($timeline) {
switch($item['type']) { foreach($timeline as &$item) {
case 'add_version': switch($item['type']) {
$msg = getMLText('timeline_'.$item['type'], array('document'=>$item['document']->getName(), 'version'=> $item['version'])); case 'add_version':
break; $msg = getMLText('timeline_'.$item['type'], array('document'=>$item['document']->getName(), 'version'=> $item['version']));
case 'add_file': break;
$msg = getMLText('timeline_'.$item['type'], array('document'=>$item['document']->getName())); case 'add_file':
break; $msg = getMLText('timeline_'.$item['type'], array('document'=>$item['document']->getName()));
case 'status_change': break;
$msg = getMLText('timeline_'.$item['type'], array('document'=>$item['document']->getName(), 'version'=> $item['version'], 'status'=> getOverallStatusText($item['status']))); case 'status_change':
break; $msg = getMLText('timeline_'.$item['type'], array('document'=>$item['document']->getName(), 'version'=> $item['version'], 'status'=> getOverallStatusText($item['status'])));
default: break;
$msg = '???'; default:
$msg = '???';
}
$item['msg'] = $msg;
} }
$item['msg'] = $msg; $this->printTimeline($timeline, 300, '', date('Y-m-d'));
} }
$this->printTimeline($timeline, 300, '', date('Y-m-d'));
} }
?> ?>
</div> </div>