gnh1201/seeddms-code
1
0
Fork 0
mirror of https://git.code.sf.net/p/seeddms/code synced 2025-05-12 04:31:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

propperly check return value after removing log entry

Browse Source
This commit is contained in:
Uwe Steinmann 2021-09-29 17:27:00 +02:00
parent 7a4e0e8513
commit 6d92be55fb
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
op/op.RemoveApprovalLog.php
View File

@ -93,7 +93,7 @@ if($approveStatus['type'] == 0) {
UI::exitError(getMLText("document_title", array("documentname" => htmlspecialchars($document->getName()))),getMLText("invalid_approveid")); UI::exitError(getMLText("document_title", array("documentname" => htmlspecialchars($document->getName()))),getMLText("invalid_approveid"));
$comment = $_POST["comment"]; $comment = $_POST["comment"];
if(0 == $latestContent->removeApproval($approveid, $user, $comment)) { if(true === $latestContent->removeApproval($approveid, $user, $comment)) {
$latestContent->verifyStatus(true, $user, $msg); $latestContent->verifyStatus(true, $user, $msg);
} }
header("Location:../out/out.ViewDocument.php?documentid=".$documentid."&currenttab=revapp"); header("Location:../out/out.ViewDocument.php?documentid=".$documentid."&currenttab=revapp");

2
op/op.RemoveReviewLog.php
View File

@ -94,7 +94,7 @@ if($reviewStatus['type'] == 0) {
$comment = $_POST["comment"]; $comment = $_POST["comment"];
$overallStatus = $latestContent->getStatus(); $overallStatus = $latestContent->getStatus();
if(0 == $latestContent->removeReview($reviewid, $user, $comment)) { if(true === $latestContent->removeReview($reviewid, $user, $comment)) {
$latestContent->verifyStatus(true, $user, $msg); $latestContent->verifyStatus(true, $user, $msg);
if($notifier) { if($notifier) {
$notifier->sendReviewRequestMail($latestContent, $user); $notifier->sendReviewRequestMail($latestContent, $user);