From 7990a1caefcff5cf731064fd55bcc2dbc6d4846b Mon Sep 17 00:00:00 2001
From: steinm <steinm@577cc39b-cfd1-4aa2-8bc3-eda205cea05a>
Date: Mon, 10 Oct 2011 14:10:16 +0000
Subject: [PATCH] - simplyfied code by using joinGroup() and leaveGroup()

---
 op/op.GroupView.php | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/op/op.GroupView.php b/op/op.GroupView.php
index de0b88f26..32ec5774b 100644
--- a/op/op.GroupView.php
+++ b/op/op.GroupView.php
@@ -44,23 +44,13 @@ if($ismanager) {
 	$curuser = $dms->getUser($_REQUEST['userid']);
 	$members = $group->getUsers();
 
-	// Check if user is alread in group
-	$ismember = false;
-	foreach($members as $member) {
-		if($member->getId() == $curuser->getId())
-			$ismember = true;
-	}
 	// Add user to group
 	if ($_REQUEST['action'] == "add") {
-		if(!$ismember) {
-			$group->addUser($curuser);
-		}
+		$curuser->joinGroup($group);
 	}
 	// Delete user from group
 	elseif($_REQUEST['action'] == 'del') {
-		if($ismember) {
-			$group->removeUser($curuser);
-		}
+		$curuser->leaveGroup($group);
 	}
 } else {
 	UI::exitError(getMLText("admin_tools"),getMLText("access_denied"));