gnh1201/seeddms-code
1
0
Fork 0
mirror of https://git.code.sf.net/p/seeddms/code synced 2025-02-11 17:44:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

propperly check return value of setApprovalByXX

Browse Source
This commit is contained in:
Uwe Steinmann 2021-09-29 17:25:24 +02:00
parent 7e17ea145c
commit 7aaa02cf7d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
op/op.ApproveDocument.php
View File

@ -96,7 +96,7 @@ if ($_POST["approvalType"] == "ind") {
else
$file = '';
$approvalLogID = $latestContent->setApprovalByInd($user, $user, $_POST["approvalStatus"], $comment, $file);
if(0 > $approvalLogID) {
if($approvalLogID === false || 0 > $approvalLogID) {
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("approval_update_failed"));
}
else {
@ -115,7 +115,7 @@ else if ($_POST["approvalType"] == "grp") {
else
$file = '';
$approvalLogID = $latestContent->setApprovalByGrp($group, $user, $_POST["approvalStatus"], $comment, $file);
if(0 > $approvalLogID) {
if($approvalLogID === false || 0 > $approvalLogID) {
UI::exitError(getMLText("document_title", array("documentname" => $document->getName())),getMLText("approval_update_failed"));
}
else {