From 8963879f5dc34055d7f007c938c4383b4ab8ccc4 Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Wed, 4 Feb 2015 07:41:33 +0100 Subject: [PATCH] htmlencode() the complete content in deletion dialog this used to be just the filename, but translations of the text may also contain qoutes which break the javascript --- views/bootstrap/class.Bootstrap.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/views/bootstrap/class.Bootstrap.php b/views/bootstrap/class.Bootstrap.php index 58bb1204e..90bb6dedd 100644 --- a/views/bootstrap/class.Bootstrap.php +++ b/views/bootstrap/class.Bootstrap.php @@ -1352,7 +1352,7 @@ $('#delete-document-btn-".$docid."').popover({ title: '".getMLText("rm_document")."', placement: 'left', html: true, - content: \"
".getMLText("confirm_rm_document", array ("documentname" => htmlspecialchars($document->getName(), ENT_QUOTES)))."
\"}); + content: \"
".htmlspecialchars(getMLText("confirm_rm_document", array ("documentname" => $document->getName())), ENT_QUOTES)."
\"}); "); if($return) return $content; @@ -1381,7 +1381,7 @@ $('#delete-folder-btn-".$folderid."').popover({ title: '".getMLText("rm_folder")."', placement: 'left', html: true, - content: \"
".getMLText("confirm_rm_folder", array ("foldername" => htmlspecialchars($folder->getName(), ENT_QUOTES)))."
\"}); + content: \"
".htmlspecialchars(getMLText("confirm_rm_folder", array ("foldername" => $folder->getName())), ENT_QUOTES)."
\"}); "); if($return) return $content;