From 2c297b5e1cc12e197c0eea262da2483bcdec0191 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 29 Mar 2016 07:59:20 +0200
Subject: [PATCH 01/10] take out javascript from html (Closes #253)

---
 styles/bootstrap/application.js     | 3 +++
 views/bootstrap/class.Bootstrap.php | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/styles/bootstrap/application.js b/styles/bootstrap/application.js
index bd0da6354..220e326ed 100644
--- a/styles/bootstrap/application.js
+++ b/styles/bootstrap/application.js
@@ -382,6 +382,9 @@ $(document).ready( function() {
 		});
 	});
 
+	$('button.history-back').on('click', function(event) {
+		window.history.back();
+	});
 });
 
 function onAddClipboard(ev) { /* {{{ */
diff --git a/views/bootstrap/class.Bootstrap.php b/views/bootstrap/class.Bootstrap.php
index 90580d2ee..7082cae33 100644
--- a/views/bootstrap/class.Bootstrap.php
+++ b/views/bootstrap/class.Bootstrap.php
@@ -1195,7 +1195,7 @@ $('#clearfilename<?php print $formName ?>').click(function(ev) {
 		print "<h4>".getMLText('error')."!</h4>";
 		print htmlspecialchars($error);
 		print "</div>";
-		print "<div><button class=\"btn\" onclick=\"window.history.back();\">".getMLText('back')."</button></div>";
+		print "<div><button class=\"btn history-back\">".getMLText('back')."</button></div>";
 		
 		$this->contentEnd();
 		$this->htmlEndPage();

From 8ac0a99e09eb4f5bed658402cdf5d8b0fa38c3a4 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 29 Mar 2016 08:03:08 +0200
Subject: [PATCH 02/10] take out last empty line (Closes: #252, #254)

causes a header to be send to early
---
 views/bootstrap/class.Search.php | 1 -
 1 file changed, 1 deletion(-)

diff --git a/views/bootstrap/class.Search.php b/views/bootstrap/class.Search.php
index 7d0ebf530..023c2d0e6 100644
--- a/views/bootstrap/class.Search.php
+++ b/views/bootstrap/class.Search.php
@@ -628,4 +628,3 @@ class SeedDMS_View_Search extends SeedDMS_Bootstrap_Style {
 	} /* }}} */
 }
 ?>
-

From ae1afe4c23e96c11ab5f8148665c41a829f26033 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 29 Mar 2016 08:12:20 +0200
Subject: [PATCH 03/10] set micro sec. of stream_select() to 200000

reduces cpu load if timeout was set to 0
---
 SeedDMS_Lucene/Lucene/IndexedDocument.php       | 2 +-
 SeedDMS_Preview/Preview/Previewer.php           | 2 +-
 SeedDMS_SQLiteFTS/SQLiteFTS/IndexedDocument.php | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/SeedDMS_Lucene/Lucene/IndexedDocument.php b/SeedDMS_Lucene/Lucene/IndexedDocument.php
index c9d5c6a1e..2a90a39b1 100644
--- a/SeedDMS_Lucene/Lucene/IndexedDocument.php
+++ b/SeedDMS_Lucene/Lucene/IndexedDocument.php
@@ -42,7 +42,7 @@ class SeedDMS_Lucene_IndexedDocument extends Zend_Search_Lucene_Document {
 		do {
 			$timeleft = $timeout - time();
 			$read = array($pipes[1]);
-			stream_select($read, $write = NULL, $exeptions = NULL, $timeleft, NULL);
+			stream_select($read, $write = NULL, $exeptions = NULL, $timeleft, 200000);
 					 
 			if (!empty($read)) {
 				$output .= fread($pipes[1], 8192);
diff --git a/SeedDMS_Preview/Preview/Previewer.php b/SeedDMS_Preview/Preview/Previewer.php
index cc493c588..33160489f 100644
--- a/SeedDMS_Preview/Preview/Previewer.php
+++ b/SeedDMS_Preview/Preview/Previewer.php
@@ -75,7 +75,7 @@ class SeedDMS_Preview_Previewer {
 		do {
 			$timeleft = $timeout - time();
 			$read = array($pipes[1]);
-			stream_select($read, $write = NULL, $exeptions = NULL, $timeleft, NULL);
+			stream_select($read, $write = NULL, $exeptions = NULL, $timeleft, 200000);
 					 
 			if (!empty($read)) {
 				$output .= fread($pipes[1], 8192);
diff --git a/SeedDMS_SQLiteFTS/SQLiteFTS/IndexedDocument.php b/SeedDMS_SQLiteFTS/SQLiteFTS/IndexedDocument.php
index d28e254d0..5228570ca 100644
--- a/SeedDMS_SQLiteFTS/SQLiteFTS/IndexedDocument.php
+++ b/SeedDMS_SQLiteFTS/SQLiteFTS/IndexedDocument.php
@@ -47,7 +47,7 @@ class SeedDMS_SQLiteFTS_IndexedDocument extends SeedDMS_SQLiteFTS_Document {
 		do {
 			$timeleft = $timeout - time();
 			$read = array($pipes[1]);
-			stream_select($read, $write = NULL, $exeptions = NULL, $timeleft, NULL);
+			stream_select($read, $write = NULL, $exeptions = NULL, $timeleft, 200000);
 					 
 			if (!empty($read)) {
 				$output .= fread($pipes[1], 8192);

From 634b9e86c420b0cdc74b24daac970dd914c659a0 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 29 Mar 2016 08:13:22 +0200
Subject: [PATCH 04/10] start new version 1.1.8

---
 SeedDMS_Lucene/package.xml | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/SeedDMS_Lucene/package.xml b/SeedDMS_Lucene/package.xml
index b7dee2403..c37770104 100644
--- a/SeedDMS_Lucene/package.xml
+++ b/SeedDMS_Lucene/package.xml
@@ -11,10 +11,10 @@
   <email>uwe@steinmann.cx</email>
   <active>yes</active>
  </lead>
- <date>2016-02-01</date>
- <time>09:14:07</time>
+ <date>2016-03-29</date>
+ <time>08:11:19</time>
  <version>
-  <release>1.1.7</release>
+  <release>1.1.8</release>
   <api>1.1.7</api>
  </version>
  <stability>
@@ -23,7 +23,7 @@
  </stability>
  <license uri="http://opensource.org/licenses/gpl-license">GPL License</license>
  <notes>
-add command for indexing postѕcript files
+set last parameter of stream_select() to 200000 micro sec. in case the timeout in sec. is set to 0
  </notes>
  <contents>
   <dir baseinstalldir="SeedDMS" name="/">
@@ -202,5 +202,21 @@ declare SeeDMS_Lucene_Indexer::open() static
 run external commands with a timeout
    </notes>
   </release>
+  <release>
+   <date>2016-02-01</date>
+   <time>09:14:07</time>
+   <version>
+    <release>1.1.7</release>
+    <api>1.1.7</api>
+   </version>
+   <stability>
+    <release>stable</release>
+    <api>stable</api>
+   </stability>
+   <license uri="http://opensource.org/licenses/gpl-license">GPL License</license>
+   <notes>
+add command for indexing postѕcript files
+   </notes>
+  </release>
  </changelog>
 </package>

From 2bef65d6ff35f1fa55f59b2cd26489a756c849eb Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 29 Mar 2016 08:13:56 +0200
Subject: [PATCH 05/10] start new version 1.1.7

---
 SeedDMS_Preview/package.xml | 26 +++++++++++++++++++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/SeedDMS_Preview/package.xml b/SeedDMS_Preview/package.xml
index 3bf524a76..f2d964f76 100644
--- a/SeedDMS_Preview/package.xml
+++ b/SeedDMS_Preview/package.xml
@@ -11,11 +11,11 @@
   <email>uwe@steinmann.cx</email>
   <active>yes</active>
  </lead>
- <date>2016-03-08</date>
- <time>09:36:57</time>
+ <date>2016-03-29</date>
+ <time>08:07:14</time>
  <version>
-  <release>1.1.6</release>
-  <api>1.1.6</api>
+  <release>1.1.7</release>
+  <api>1.1.7</api>
  </version>
  <stability>
   <release>stable</release>
@@ -23,7 +23,7 @@
  </stability>
  <license uri="http://opensource.org/licenses/gpl-license">GPL License</license>
  <notes>
-check if object passed to createPreview(), hasPreview() is not null
+set last parameter of stream_select() to 200000 micro sec. in case the timeout in sec. is set to 0
  </notes>
  <contents>
   <dir baseinstalldir="SeedDMS" name="/">
@@ -164,5 +164,21 @@ add method getFilesize()
 timeout for external commands can be passed to contructor of SeedDMS_Preview_Previewer
    </notes>
   </release>
+  <release>
+   <date>2016-03-08</date>
+   <time>09:36:57</time>
+   <version>
+    <release>1.1.6</release>
+    <api>1.1.6</api>
+   </version>
+   <stability>
+    <release>stable</release>
+    <api>stable</api>
+   </stability>
+   <license uri="http://opensource.org/licenses/gpl-license">GPL License</license>
+   <notes>
+check if object passed to createPreview(), hasPreview() is not null
+   </notes>
+  </release>
  </changelog>
 </package>

From da21b07a157445de36ae5d32513397cad6005a3b Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 29 Mar 2016 08:14:13 +0200
Subject: [PATCH 06/10] start new version 1.0.5

---
 SeedDMS_SQLiteFTS/package.xml | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/SeedDMS_SQLiteFTS/package.xml b/SeedDMS_SQLiteFTS/package.xml
index 4425ba1ea..c55c1ced0 100644
--- a/SeedDMS_SQLiteFTS/package.xml
+++ b/SeedDMS_SQLiteFTS/package.xml
@@ -11,10 +11,10 @@
   <email>uwe@steinmann.cx</email>
   <active>yes</active>
  </lead>
- <date>2016-03-15</date>
- <time>15:59:07</time>
+ <date>2016-03-29</date>
+ <time>08:09:48</time>
  <version>
-  <release>1.0.4</release>
+  <release>1.0.5</release>
   <api>1.0.1</api>
  </version>
  <stability>
@@ -23,7 +23,7 @@
  </stability>
  <license uri="http://opensource.org/licenses/gpl-license">GPL License</license>
  <notes>
-make it work with sqlite3 &lt; 3.8.0
+set last parameter of stream_select() to 200000 micro sec. in case the timeout in sec. is set to 0
  </notes>
  <contents>
   <dir baseinstalldir="SeedDMS" name="/">
@@ -130,5 +130,21 @@ check if index exists before removing it when creating a new one
 add command for indexing postѕcript files
    </notes>
   </release>
+  <release>
+   <date>2016-03-15</date>
+   <time>15:59:07</time>
+   <version>
+    <release>1.0.4</release>
+    <api>1.0.1</api>
+   </version>
+   <stability>
+    <release>stable</release>
+    <api>stable</api>
+   </stability>
+   <license uri="http://opensource.org/licenses/gpl-license">GPL License</license>
+   <notes>
+make it work with sqlite3 &lt; 3.8.0
+   </notes>
+  </release>
  </changelog>
 </package>

From 24f300e8d5ee39b4187c8a6b9ebef5cf506898c1 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 29 Mar 2016 08:14:31 +0200
Subject: [PATCH 07/10] add changelog for 4.3.26

---
 CHANGELOG | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/CHANGELOG b/CHANGELOG
index 6b5d37625..e18236380 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,3 +1,10 @@
+--------------------------------------------------------------------------------
+                     Changes in version 4.3.26
+--------------------------------------------------------------------------------
+- move some left over javascript from html code into application.js (Closes #253)
+- take out last empty line from view/bootstrap/class.Search.php which causes a
+  header to be send to early (Closes: #252, #254) 
+
 --------------------------------------------------------------------------------
                      Changes in version 4.3.25
 --------------------------------------------------------------------------------

From ebb53440dfc7364df3ab7345c8a0060b846bd83b Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 29 Mar 2016 08:32:32 +0200
Subject: [PATCH 08/10] remove some old code, mark code as deprecated

---
 views/bootstrap/class.Bootstrap.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/views/bootstrap/class.Bootstrap.php b/views/bootstrap/class.Bootstrap.php
index 7082cae33..5f7187a2d 100644
--- a/views/bootstrap/class.Bootstrap.php
+++ b/views/bootstrap/class.Bootstrap.php
@@ -958,6 +958,10 @@ function folderSelected<?php echo $formName ?>(id, name) {
 <?php
 	} /* }}} */
 
+	/**
+	 * Do not use anymore. Was previously used to show the category
+	 * chooser. It has been replaced by a select box
+	 */
 	function printCategoryChooser($formName, $categories=array()) { /* {{{ */
 ?>
 <script language="JavaScript">
@@ -1115,7 +1119,6 @@ $('#acceptkeywords').click(function(ev) {
   </div>
   <div class="modal-footer">
     <button class="btn btn-primary" data-dismiss="modal" aria-hidden="true"><?php printMLText("close") ?></button>
-<!--    <button class="btn" data-dismiss="modal" aria-hidden="true" onClick="acceptCategories();"><i class="icon-save"></i> <?php printMLText("save") ?></button> -->
   </div>
 </div>
 <?php

From da6af81ec91cb3452cf68c37a01bee28d375b614 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Wed, 30 Mar 2016 14:06:27 +0200
Subject: [PATCH 09/10] set width of .chosen-container on search page

---
 styles/bootstrap/application.css | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/styles/bootstrap/application.css b/styles/bootstrap/application.css
index 9817043ba..d050492ab 100644
--- a/styles/bootstrap/application.css
+++ b/styles/bootstrap/application.css
@@ -98,6 +98,11 @@ div.statusbar a.btn {
 	margin-bottom: 10px;
 }
 
+#database .chosen-container,
+#fulltext .chosen-container {
+	width: 95% !important;
+}
+
 .chosen-container-multi .chosen-choices {
 	border: 1px solid #cccccc;
 	border-radius: 4px;

From 5c32c6edbe752d4265fa2d89bfa12a8331567599 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Wed, 30 Mar 2016 14:16:23 +0200
Subject: [PATCH 10/10] replace '<?=' by '<?php echo'

---
 views/bootstrap/class.Bootstrap.php |  8 ++++----
 views/bootstrap/class.Timeline.php  | 18 +++++++++---------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/views/bootstrap/class.Bootstrap.php b/views/bootstrap/class.Bootstrap.php
index 5f7187a2d..d2d0398ef 100644
--- a/views/bootstrap/class.Bootstrap.php
+++ b/views/bootstrap/class.Bootstrap.php
@@ -1063,7 +1063,7 @@ $('#acceptkeywords').click(function(ev) {
 		case SeedDMS_Core_AttributeDefinition::type_date:
 ?>
         <span class="input-append date datepicker" style="display: inline;" data-date="<?php echo date('Y-m-d'); ?>" data-date-format="yyyy-mm-dd" data-date-language="<?php echo str_replace('_', '-', $this->params['session']->getLanguage()); ?>">
-					<input class="span4" size="16" name="<?= $fieldname ?>[<?= $attrdef->getId() ?>]" type="text" value="<?php if($objvalue) echo $objvalue; else echo "" /*date('Y-m-d')*/; ?>">
+					<input class="span4" size="16" name="<?php echo $fieldname ?>[<?php echo $attrdef->getId() ?>]" type="text" value="<?php if($objvalue) echo $objvalue; else echo "" /*date('Y-m-d')*/; ?>">
           <span class="add-on"><i class="icon-calendar"></i></span>
 				</span>
 <?php
@@ -2273,7 +2273,7 @@ mayscript>
 			'editable': false,
 			'selectable': true,
 			'style': 'box',
-			'locale': '<?= $this->params['session']->getLanguage() ?>'
+			'locale': '<?php echo $this->params['session']->getLanguage() ?>'
 		};
 
 		function onselect() {
@@ -2292,7 +2292,7 @@ mayscript>
 		timeline = new links.Timeline(document.getElementById('timeline'), options);
 		links.events.addListener(timeline, 'select', onselect);
 		$.getJSON(
-			'<?= $timelineurl ?>', 
+			'<?php echo $timelineurl ?>', 
 			function(data) {
 				$.each( data, function( key, val ) {
 					val.start = new Date(val.start);
@@ -2306,7 +2306,7 @@ mayscript>
 
 	protected function printTimelineHtml($height) { /* {{{ */
 ?>
-	<div id="timeline" style="height: <?= $height ?>px;"></div>
+	<div id="timeline" style="height: <?php echo $height ?>px;"></div>
 <?php
 	} /* }}} */
 
diff --git a/views/bootstrap/class.Timeline.php b/views/bootstrap/class.Timeline.php
index f5d941104..4832ffb61 100644
--- a/views/bootstrap/class.Timeline.php
+++ b/views/bootstrap/class.Timeline.php
@@ -205,7 +205,7 @@ $(document).ready(function () {
 ?>
 <form action="../out/out.Timeline.php" class="form form-inline" name="form1" id="form1">
 	<div class="control-group">
-		<label class="control-label" for="startdate"><?= getMLText('date') ?></label>
+		<label class="control-label" for="startdate"><?php printMLText('date') ?></label>
 		<div class="controls">
        <span class="input-append date" style="display: inline;" id="fromdate" data-date="<?php echo date('Y-m-d', $from); ?>" data-date-format="yyyy-mm-dd" data-date-language="<?php echo str_replace('_', '-', $this->params['session']->getLanguage()); ?>">
 			 <input type="text" class="input-small" name="fromdate" value="<?php echo date('Y-m-d', $from); ?>"/>
@@ -218,15 +218,15 @@ $(document).ready(function () {
 		</div>
 	</div>
 	<div class="control-group">
-		<label class="control-label" for="skip"><?= getMLText('exclude_items') ?></label>
+		<label class="control-label" for="skip"><?php printMLText('exclude_items') ?></label>
 		<div class="controls">
-			<input type="checkbox" name="skip[]" value="add_file" <?= ($skip &&  in_array('add_file', $skip)) ? 'checked' : '' ?>> <?= getMLText('timeline_skip_add_file') ?><br />
-			<input type="checkbox" name="skip[]" value="status_change_0" <?= ($skip && in_array('status_change_0', $skip)) ? 'checked' : '' ?>> <?= getMLText('timeline_skip_status_change_0') ?><br />
-			<input type="checkbox" name="skip[]" value="status_change_1" <?= ($skip && in_array('status_change_1', $skip)) ? 'checked' : '' ?>> <?= getMLText('timeline_skip_status_change_1') ?><br />
-			<input type="checkbox" name="skip[]" value="status_change_2" <?= ($skip && in_array('status_change_2', $skip)) ? 'checked' : '' ?>> <?= getMLText('timeline_skip_status_change_2') ?><br />
-			<input type="checkbox" name="skip[]" value="status_change_3" <?= ($skip && in_array('status_change_3', $skip)) ? 'checked' : '' ?>> <?= getMLText('timeline_skip_status_change_3') ?><br />
-			<input type="checkbox" name="skip[]" value="status_change_-1" <?= ($skip && in_array('status_change_-1', $skip)) ? 'checked' : '' ?>> <?= getMLText('timeline_skip_status_change_-1') ?><br />
-			<input type="checkbox" name="skip[]" value="status_change_-3" <?= ($skip && in_array('status_change_-3', $skip)) ? 'checked' : '' ?>> <?= getMLText('timeline_skip_status_change_-3') ?><br />
+			<input type="checkbox" name="skip[]" value="add_file" <?php echo ($skip &&  in_array('add_file', $skip)) ? 'checked' : '' ?>> <?php printMLText('timeline_skip_add_file') ?><br />
+			<input type="checkbox" name="skip[]" value="status_change_0" <?php echo ($skip && in_array('status_change_0', $skip)) ? 'checked' : '' ?>> <?php printMLText('timeline_skip_status_change_0') ?><br />
+			<input type="checkbox" name="skip[]" value="status_change_1" <?php echo ($skip && in_array('status_change_1', $skip)) ? 'checked' : '' ?>> <?php printMLText('timeline_skip_status_change_1') ?><br />
+			<input type="checkbox" name="skip[]" value="status_change_2" <?php echo ($skip && in_array('status_change_2', $skip)) ? 'checked' : '' ?>> <?php printMLText('timeline_skip_status_change_2') ?><br />
+			<input type="checkbox" name="skip[]" value="status_change_3" <?php echo ($skip && in_array('status_change_3', $skip)) ? 'checked' : '' ?>> <?php printMLText('timeline_skip_status_change_3') ?><br />
+			<input type="checkbox" name="skip[]" value="status_change_-1" <?php echo ($skip && in_array('status_change_-1', $skip)) ? 'checked' : '' ?>> <?php printMLText('timeline_skip_status_change_-1') ?><br />
+			<input type="checkbox" name="skip[]" value="status_change_-3" <?php echo ($skip && in_array('status_change_-3', $skip)) ? 'checked' : '' ?>> <?php printMLText('timeline_skip_status_change_-3') ?><br />
 		</div>
 	</div>
 	<div class="control-group">