gnh1201/seeddms-code
1
0
Fork 0
mirror of https://git.code.sf.net/p/seeddms/code synced 2024-10-17 05:22:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

admis are allowed to change approver/reviewer after first approval/review

Browse Source
This commit is contained in:
Uwe Steinmann 2019-02-01 09:00:16 +01:00
parent 4b1e933c76
commit 9e1dff071a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
inc/inc.ClassAccessOperation.php
View File

@ -125,8 +125,9 @@ class SeedDMS_AccessOperation {
* reviewers/approvers is only allowed if version modification is turned on * reviewers/approvers is only allowed if version modification is turned on
* in the settings and the document has not been reviewed/approved by any * in the settings and the document has not been reviewed/approved by any
* user/group already. * user/group already.
* The admin may even set reviewers/approvers if is disallowed in the * The admin may even set reviewers/approvers after the review/approval
* settings. * process has been started, but only if _allowChangeRevAppInProcess
* explicitly allows it.
*/ */
function maySetReviewersApprovers($document) { /* {{{ */ function maySetReviewersApprovers($document) { /* {{{ */
if(get_class($document) == $this->dms->getClassname('document')) { if(get_class($document) == $this->dms->getClassname('document')) {
@ -144,7 +145,7 @@ class SeedDMS_AccessOperation {
if($r['status'] == 1 || $r['status'] == -1) if($r['status'] == 1 || $r['status'] == -1)
$hasapproval = true; $hasapproval = true;
} }
if ((($this->settings->_enableVersionModification && ($document->getAccessMode($this->user) == M_ALL)) || $this->user->isAdmin()) && (($status["status"]==S_DRAFT_REV && !$hasreview) || ($status["status"]==S_DRAFT_APP && !$hasreview && !$hasapproval) || $status["status"]==S_DRAFT)) { if ((($this->settings->_enableVersionModification && ($document->getAccessMode($this->user) == M_ALL)) || $this->user->isAdmin()) && (($status["status"]==S_DRAFT_REV && (!$hasreview || ($this->user->isAdmin() && $this->settings->_allowChangeRevAppInProcess))) || ($status["status"]==S_DRAFT_APP && ((!$hasreview && !$hasapproval) || ($this->user->isAdmin() && $this->settings->_allowChangeRevAppInProcess))) || $status["status"]==S_DRAFT)) {
return true; return true;
} }
} }