From a3d92f5b72ffb711a28df5801c1cabc94871740b Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Mon, 14 Dec 2020 07:52:39 +0100
Subject: [PATCH] return error if postAddDocument fails

---
 controllers/class.AddDocument.php | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/controllers/class.AddDocument.php b/controllers/class.AddDocument.php
index 0986a2961..482c5ec35 100644
--- a/controllers/class.AddDocument.php
+++ b/controllers/class.AddDocument.php
@@ -133,7 +133,7 @@ class SeedDMS_Controller_AddDocument extends SeedDMS_Controller_Common {
 				if($document->getGroupAccessMode($notgroup) >= M_READ)
 					$res = $document->addNotify($notgroup->getID(), false);
 			}
-		} elseif($result === false) {
+		} elseif($document === false) {
 			if(empty($this->errormsg))
 				$this->errormsg = 'hook_addDocument_failed';
 			return false;
@@ -147,7 +147,10 @@ class SeedDMS_Controller_AddDocument extends SeedDMS_Controller_Common {
 			}
 		}
 
-		if(!$this->callHook('postAddDocument', $document)) {
+		if(false ==== $this->callHook('postAddDocument', $document)) {
+			if(empty($this->errormsg))
+				$this->errormsg = 'hook_postAddDocument_failed';
+			return false;
 		}
 
 		return $document;