From adba550a6392a04894e3577e60c216d7064ec67f Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Thu, 16 Sep 2021 16:17:24 +0200 Subject: [PATCH] minor simplification of sql statement --- SeedDMS_Core/Core/inc.ClassGroup.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/SeedDMS_Core/Core/inc.ClassGroup.php b/SeedDMS_Core/Core/inc.ClassGroup.php index 696613600..890cba355 100644 --- a/SeedDMS_Core/Core/inc.ClassGroup.php +++ b/SeedDMS_Core/Core/inc.ClassGroup.php @@ -284,7 +284,7 @@ class SeedDMS_Core_Group { /* {{{ */ * set to true, otherwise does not care about manager status * @return boolean true if user is member, otherwise false */ - function isMember($user,$asManager=false) { /* {{{ */ + function isMember($user, $asManager=false) { /* {{{ */ if (isset($this->_users)&&!$asManager) { foreach ($this->_users as $usr) if ($usr->getID() == $user->getID()) @@ -293,8 +293,9 @@ class SeedDMS_Core_Group { /* {{{ */ } $db = $this->_dms->getDB(); - if ($asManager) $queryStr = "SELECT * FROM `tblGroupMembers` WHERE `groupID` = " . $this->_id . " AND `userID` = " . $user->getID() . " AND `manager` = 1"; - else $queryStr = "SELECT * FROM `tblGroupMembers` WHERE `groupID` = " . $this->_id . " AND `userID` = " . $user->getID(); + $queryStr = "SELECT * FROM `tblGroupMembers` WHERE `groupID` = " . $this->_id . " AND `userID` = " . $user->getID(); + if ($asManager) + $queryStr .= " AND `manager` = 1"; $resArr = $db->getResultArray($queryStr);