From 04c0b62b8c3c82a9fc4b47ecaa159bb91c487501 Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Tue, 2 Aug 2016 11:33:21 +0200 Subject: [PATCH 1/2] fix setting reviewer/approver for admins/owners --- op/op.SetReviewersApprovers.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/op/op.SetReviewersApprovers.php b/op/op.SetReviewersApprovers.php index 4e69ca64d..baa84a0e7 100644 --- a/op/op.SetReviewersApprovers.php +++ b/op/op.SetReviewersApprovers.php @@ -62,7 +62,7 @@ $folder = $document->getFolder(); // Retrieve a list of all users and groups that have review / approve // privileges. -$docAccess = $document->getReadAccessList(); +$docAccess = $document->getReadAccessList($settings->_enableAdminRevApp, $settings->_enableOwnerRevApp); $accessIndex = array("i"=>array(), "g"=>array()); foreach ($docAccess["users"] as $i=>$da) { $accessIndex["i"][$da->getID()] = $i; From fa4dddd4036b88d1b1ae077728a20b446b8e6ee0 Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Tue, 2 Aug 2016 11:33:46 +0200 Subject: [PATCH 2/2] add entry for 4.3.28 --- CHANGELOG | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG b/CHANGELOG index c427f64e7..0120147ae 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -2,6 +2,7 @@ Changes in version 4.3.28 -------------------------------------------------------------------------------- - add expiration in list of documents +- fix SetReviewersApprovers if reviewer/approver is an admin or the owner -------------------------------------------------------------------------------- Changes in version 4.3.27