From ce2ee995fc4e9c07e0a50864b1b51f23366dd81e Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 1 Sep 2020 14:59:16 +0200
Subject: [PATCH] getValueSetSeparator() returns ',' for type_user and
 type_group

---
 SeedDMS_Core/Core/inc.ClassAttribute.php | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/SeedDMS_Core/Core/inc.ClassAttribute.php b/SeedDMS_Core/Core/inc.ClassAttribute.php
index 2e9e6d11c..8090c915b 100644
--- a/SeedDMS_Core/Core/inc.ClassAttribute.php
+++ b/SeedDMS_Core/Core/inc.ClassAttribute.php
@@ -168,6 +168,7 @@ class SeedDMS_Core_Attribute { /* {{{ */
 
 			if(is_array($values)) {
 				if($values) {
+					$vsep = $this->getValueSetSeparator();
 					if($valueset) {
 						$error = false;
 						foreach($values as $v) {
@@ -176,9 +177,9 @@ class SeedDMS_Core_Attribute { /* {{{ */
 						if($error)
 							return false;
 						$valuesetstr = $this->_attrdef->getValueSet();
-						$value = $valuesetstr[0].implode($valuesetstr[0], $values);
+						$value = $vsep.implode($vsep, $values);
 					} else {
-						$value = ','.implode(',', $values);
+						$value = $vsep.implode($vsep, $values);
 					}
 				} else {
 					$value = '';
@@ -649,10 +650,16 @@ class SeedDMS_Core_AttributeDefinition { /* {{{ */
 	 * @return string separator or an empty string if a value set is not set
 	 */
 	function getValueSetSeparator() { /* {{{ */
-		if(strlen($this->_valueset) > 1)
+		if(strlen($this->_valueset) > 1) {
 			return $this->_valueset[0];
-		else
+		} elseif($this->_multiple) {
+			if($this->_type == SeedDMS_Core_AttributeDefinition::type_user || $this->_type == SeedDMS_Core_AttributeDefinition::type_group)
+				return ',';
+			else
+				return '';
+		} else {
 			return '';
+		}
 	} /* }}} */
 
 	/**