gnh1201/seeddms-code
1
0
Fork 0
mirror of https://git.code.sf.net/p/seeddms/code synced 2025-05-13 21:21:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

do not validate value in SeedDMS_Core_Attribute::setValue(), it should have been done before

Browse Source
This commit is contained in:
Uwe Steinmann 2021-03-06 15:26:18 +01:00
parent 2a5a5b2053
commit ceed62bf2b
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
SeedDMS_Core/Core/inc.ClassAttribute.php
View File

@ -177,12 +177,14 @@ class SeedDMS_Core_Attribute { /* {{{ */
if($values) { if($values) {
$vsep = $this->getValueSetSeparator(); $vsep = $this->getValueSetSeparator();
if($valueset) { if($valueset) {
/* Validation should have been done before
$error = false; $error = false;
foreach($values as $v) { foreach($values as $v) {
if(!in_array($v, $valueset)) { $error = true; break; } if(!in_array($v, $valueset)) { $error = true; break; }
} }
if($error) if($error)
return false; return false;
*/
$valuesetstr = $this->_attrdef->getValueSet(); $valuesetstr = $this->_attrdef->getValueSet();
$value = $vsep.implode($vsep, $values); $value = $vsep.implode($vsep, $values);
} else { } else {
@ -203,12 +205,14 @@ class SeedDMS_Core_Attribute { /* {{{ */
} }
if($valueset) { if($valueset) {
/* Validation should have been done before
$error = false; $error = false;
foreach($values as $v) { foreach($values as $v) {
if(!in_array($v, $valueset)) { $error = true; break; } if(!in_array($v, $valueset)) { $error = true; break; }
} }
if($error) if($error)
return false; return false;
*/
$value = $valuesetstr[0].implode($valuesetstr[0], $values); $value = $valuesetstr[0].implode($valuesetstr[0], $values);
} else { } else {
$value = ','.implode(',', $values); $value = ','.implode(',', $values);