From cf2bb2b4c3b3ef9f2aa207a952887ca0b6546093 Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Thu, 24 Jul 2025 09:13:59 +0200 Subject: [PATCH 1/5] more documentation for method documentListRow() --- views/bootstrap/class.Bootstrap.php | 2 ++ views/bootstrap4/class.Bootstrap4.php | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/views/bootstrap/class.Bootstrap.php b/views/bootstrap/class.Bootstrap.php index ad152a6d4..8d6c4f271 100644 --- a/views/bootstrap/class.Bootstrap.php +++ b/views/bootstrap/class.Bootstrap.php @@ -3269,6 +3269,8 @@ $('body').on('click', '[id^=\"table-row-folder\"] td:nth-child(2)', function(ev) * @param object $document * @param object $previewer * @param boolean $skipcont set to true if embrasing tr shall be skipped + * In that case call documentListRowStart() before and documentListRowEnd() + * after this method. */ function documentListRow($document, $previewer, $skipcont=false, $version=0, $extracontent=array()) { /* {{{ */ $dms = $this->params['dms']; diff --git a/views/bootstrap4/class.Bootstrap4.php b/views/bootstrap4/class.Bootstrap4.php index 68577b2f5..3d253d11d 100644 --- a/views/bootstrap4/class.Bootstrap4.php +++ b/views/bootstrap4/class.Bootstrap4.php @@ -3317,7 +3317,9 @@ $('body').on('click', '[id^=\"table-row-folder\"] td:nth-child(2)', function(ev) * * @param object $document * @param object $previewer - * @param boolean $skipcont set to true if embrasing tr shall be skipped + * @param boolean $skipcont set to true if embrasing tr shall be skipped. + * In that case call documentListRowStart() before and documentListRowEnd() + * after this method. */ function documentListRow($document, $previewer, $skipcont=false, $version=0, $extracontent=array()) { /* {{{ */ $dms = $this->params['dms']; From ee50953d11530390de2310d30ad338ba891a1c4b Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Thu, 24 Jul 2025 09:15:18 +0200 Subject: [PATCH 2/5] fix list of related documents when hook documentListItem() is implemented --- views/bootstrap/class.ViewDocument.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/views/bootstrap/class.ViewDocument.php b/views/bootstrap/class.ViewDocument.php index 0f8b8f0fa..9663580ad 100644 --- a/views/bootstrap/class.ViewDocument.php +++ b/views/bootstrap/class.ViewDocument.php @@ -1608,7 +1608,6 @@ $(document).ready( function() { $responsibleUser = $link->getUser(); $targetDoc = $link->getTarget(); - echo $this->documentListRowStart($targetDoc); $targetDoc->verifyLastestContentExpriry(); $txt = $this->callHook('documentListItem', $targetDoc, $previewer, false, 'reverselinks'); if(is_string($txt)) @@ -1616,6 +1615,7 @@ $(document).ready( function() { else { $extracontent = array(); $extracontent['below_title'] = $this->getListRowPath($targetDoc); + echo $this->documentListRowStart($targetDoc); echo $this->documentListRow($targetDoc, $previewer, true, 0, $extracontent); } print ""; @@ -1676,7 +1676,6 @@ $(document).ready( function() { $responsibleUser = $link->getUser(); $sourceDoc = $link->getDocument(); - echo $this->documentListRowStart($sourceDoc); $sourceDoc->verifyLastestContentExpriry(); $txt = $this->callHook('documentListItem', $sourceDoc, $previewer, false, 'reverselinks'); if(is_string($txt)) @@ -1684,6 +1683,7 @@ $(document).ready( function() { else { $extracontent = array(); $extracontent['below_title'] = $this->getListRowPath($sourceDoc); + echo $this->documentListRowStart($sourceDoc); echo $this->documentListRow($sourceDoc, $previewer, true, 0, $extracontent); } print ""; From 83ea0e0db9240c9a12d1f7eae3fc55e5aaa6127e Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Thu, 24 Jul 2025 09:16:09 +0200 Subject: [PATCH 3/5] add changes for 5.1.41 --- CHANGELOG | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG b/CHANGELOG index 3a9bbbf91..464d2506e 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -5,6 +5,7 @@ - major update of polish translation - fix getting access rights in getMandatoryApprovers() and getMandatoryReviewers() - better checking for attribute definition when build a search query +- fix list of related documents when hook documentListItem() is implemented -------------------------------------------------------------------------------- Changes in version 5.1.40 From 29d6ece06a0294a2ad994886be7d56353b366e16 Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Thu, 24 Jul 2025 09:17:03 +0200 Subject: [PATCH 4/5] fix typo --- CHANGELOG | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG b/CHANGELOG index 464d2506e..363e5a836 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -4,7 +4,7 @@ - action when clicking on a thumbnail can be set (download or view online) - major update of polish translation - fix getting access rights in getMandatoryApprovers() and getMandatoryReviewers() -- better checking for attribute definition when build a search query +- better checking for attribute definition when building a search query - fix list of related documents when hook documentListItem() is implemented -------------------------------------------------------------------------------- From 698c82b806ff36f09f66f4a5c94204c89ca68f51 Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Thu, 24 Jul 2025 09:30:28 +0200 Subject: [PATCH 5/5] add more changes of 5.1.41 --- CHANGELOG | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 363e5a836..f861270d1 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -6,6 +6,15 @@ - fix getting access rights in getMandatoryApprovers() and getMandatoryReviewers() - better checking for attribute definition when building a search query - fix list of related documents when hook documentListItem() is implemented +- move EditAttributes into controller and add various hooks (like EditDocument) +- move sending notification mail when attributes are changed into + Notification Service +- more documentation on configuring LDAP +- collect output controller/view hooks with '+' instead of array_merge() +- add hook 'searchExportOptions' +- show how many users have to review/approve a document and how many did + already (in menu task list and document list) +- break long original file names on viewDocument page -------------------------------------------------------------------------------- Changes in version 5.1.40