From ec78639d9488ed4133de9f7bce23d727d2e29db4 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Tue, 2 Jun 2015 10:18:37 +0200
Subject: [PATCH] do not hide review if workflow mode is
 traditional_only_approve

otherwise old documents which are still in review can't be reviewed
anymore
---
 views/bootstrap/class.ViewDocument.php | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/views/bootstrap/class.ViewDocument.php b/views/bootstrap/class.ViewDocument.php
index 8bc24643d..aa47a82b1 100644
--- a/views/bootstrap/class.ViewDocument.php
+++ b/views/bootstrap/class.ViewDocument.php
@@ -636,7 +636,11 @@ class SeedDMS_View_ViewDocument extends SeedDMS_Bootstrap_Style {
 		$this->contentContainerstart();
 		print "<table class=\"table-condensed\">\n";
 
-		if ($workflowmode != 'traditional_only_approval' && is_array($reviewStatus) && count($reviewStatus)>0) {
+		/* Just check fo an exting reviewStatus, even workflow mode is set
+		 * to traditional_only_approval. There may be old documents which
+		 * are still in S_DRAFT_REV.
+		 */
+		if (/*$workflowmode != 'traditional_only_approval' &&*/ is_array($reviewStatus) && count($reviewStatus)>0) {
 
 			print "<tr><td colspan=5>\n";
 			$this->contentSubHeading(getMLText("reviewers"));
@@ -772,7 +776,12 @@ class SeedDMS_View_ViewDocument extends SeedDMS_Bootstrap_Style {
 ?>
 			<div class="row-fluid">
 <?php
-			if($workflowmode != 'traditional_only_approval') {
+			/* Check for an existing review log, even if the workflowmode
+			 * is set to traditional_only_approval. There may be old documents
+			 * that still have a review log if the workflow mode has been
+			 * changed afterwards.
+			 */
+			if($latestContent->getReviewStatus(10) /*$workflowmode != 'traditional_only_approval'*/) {
 ?>
 				<div class="span6">
 				<?php $this->printProtocol($latestContent, 'review'); ?>