From f8ceb0d56a11d610bd1b9e008016f7cc38449ac4 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Wed, 2 Apr 2025 08:03:52 +0200
Subject: [PATCH] do not set bool/array value if not exist in post data

---
 op/op.Settings.php | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/op/op.Settings.php b/op/op.Settings.php
index da5a32f9f..db2432ad6 100644
--- a/op/op.Settings.php
+++ b/op/op.Settings.php
@@ -57,10 +57,12 @@ if ($action == "saveSettings")
 	function setBoolValue($name) {
 		global $_POST, $settings;
 		if(!in_array($name, $settings->_hiddenConfFields)) {
-			if (isset($_POST[$name]) && $_POST[$name]=="on")
-				$settings->{"_".$name} = true;
-			else
-				$settings->{"_".$name} = false;
+			if (isset($_POST[$name])) {
+				if ($_POST[$name]=="on")
+					$settings->{"_".$name} = true;
+				else
+					$settings->{"_".$name} = false;
+			}
 		}
 	}
 	function setIntValue($name) {
@@ -70,11 +72,13 @@ if ($action == "saveSettings")
 	}
 	function setArrayValue($name) {
 		global $_POST, $settings;
-		if(!in_array($name, $settings->_hiddenConfFields)) {
-			if(isset($_POST[$name]) && $_POST[$name])
-				$settings->{"_".$name} = $_POST[$name];
-			else
-				$settings->{"_".$name} = array();
+		if (!in_array($name, $settings->_hiddenConfFields)) {
+			if (isset($_POST[$name])) {
+				if ($_POST[$name])
+					$settings->{"_".$name} = $_POST[$name];
+				else
+					$settings->{"_".$name} = array();
+			}
 		}
 	}
 	function setDirValue($name) {