gnh1201/seeddms-code
1
0
Fork 0
mirror of https://git.code.sf.net/p/seeddms/code synced 2025-05-12 12:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

use rename() on windows when moving an extension to its final destination

Browse Source
This commit is contained in:
Uwe Steinmann 2024-09-02 16:00:17 +02:00
parent 15c5ef1441
commit f97c42f9b7
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
inc/inc.ClassExtensionMgr.php
View File

@ -565,12 +565,16 @@ class SeedDMS_Extension_Mgr {
* location and leave the extracted archive in place. The next time an * location and leave the extracted archive in place. The next time an
* extension is imported the last extracted archive will be removed. * extension is imported the last extracted archive will be removed.
*/ */
// if(!rename($newdir, $this->extdir ."/". $extname)) { if(strpos(PHP_OS, 'WIN') === 0)
if(false === exec('mv '.escapeshellarg($newdir).' '.escapeshellarg($this->extdir."/".$extname))) { $ret = rename($newdir, $this->extdir ."/". $extname);
else
$ret = exec('mv '.escapeshellarg($newdir).' '.escapeshellarg($this->extdir."/".$extname));
if(false === $ret) {
/* If copy didn't succeed, then there is probably nothing to delete, /* If copy didn't succeed, then there is probably nothing to delete,
* but do it anyway, just to be sure not just parts of the extension * but do it anyway, just to be sure not just parts of the extension
* has been copied. * has been copied.
*/ */
$this->errmsgs[] = "Cannot move temp. extension directory to final destination";
$this->rrmdir($this->extdir ."/". $extname); $this->rrmdir($this->extdir ."/". $extname);
return false; return false;
} }