From fe8e1d2b5207669795b97cdda9f877f629e639b2 Mon Sep 17 00:00:00 2001
From: Uwe Steinmann <steinm@debian.org>
Date: Thu, 24 Mar 2016 15:41:23 +0100
Subject: [PATCH] proper check of return value of setStatus()

---
 controllers/class.ReviseDocument.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/controllers/class.ReviseDocument.php b/controllers/class.ReviseDocument.php
index 1720b270f..391e8ac14 100644
--- a/controllers/class.ReviseDocument.php
+++ b/controllers/class.ReviseDocument.php
@@ -64,7 +64,7 @@ class SeedDMS_Controller_ReviseDocument extends SeedDMS_Controller_Common {
 		$result = $this->callHook('reviseUpdateDocumentStatus', $content);
 		if($result === null) {
 			if ($revisionstatus == -1){
-				if($content->setStatus(S_REJECTED,$comment,$user)) {
+				if(!$content->setStatus(S_REJECTED,$comment,$user)) {
 					$this->error = 1;
 					$this->errormsg = "revision_update_failed";
 					return false;
@@ -94,7 +94,7 @@ class SeedDMS_Controller_ReviseDocument extends SeedDMS_Controller_Common {
 					}
 				} else {
 					$newStatus=S_IN_REVISION;
-					if($content->setStatus($newStatus,$comment,$user)) {
+					if(!$content->setStatus($newStatus,$comment,$user)) {
 						$this->error = 1;
 						$this->errormsg = "revision_update_failed";
 						return false;