From 0e6dfa1b38f44a369f4432a54ad9e01ee1848473 Mon Sep 17 00:00:00 2001
From: YAMAMOTO Takashi <yamamoto@midokura.com>
Date: Tue, 23 Apr 2024 15:57:47 +0900
Subject: [PATCH] Revert WASM_STACK_GUARD_SIZE to 1024 for non-posix platforms

Also, add comments.
---
 core/config.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/core/config.h b/core/config.h
index 4e55c3312..70ebb795e 100644
--- a/core/config.h
+++ b/core/config.h
@@ -486,7 +486,26 @@
 /* UVWASI requires larger native stack */
 #define WASM_STACK_GUARD_SIZE (4096 * 6)
 #else
+/*
+ * Use a larger default for platforms like macOS/Linux.
+ *
+ * For example, wasm_interp_call_func_bytecode + wasm_runtime_set_exception
+ * would consume >4KB stack on x86-64 macOS.
+ *
+ * Although product-mini/platforms/nuttx always overrides
+ * WASM_STACK_GUARD_SIZE, exclude NuttX here just in case.
+ */
+#if defined(__APPLE__) || (defined(__unix__) && !defined(__NuttX__))
 #define WASM_STACK_GUARD_SIZE (1024 * 5)
+#else
+/*
+ * Otherwise, assume very small requirement for now.
+ *
+ * Embedders for very small devices likely fine-tune WASM_STACK_GUARD_SIZE
+ * for their specific applications anyway.
+ */
+#define WASM_STACK_GUARD_SIZE 1024
+#endif
 #endif
 #endif