From 425efb875f4c0355bffb2f6c1977f787b30247ce Mon Sep 17 00:00:00 2001 From: YAMAMOTO Takashi Date: Mon, 8 Aug 2022 17:46:54 +0900 Subject: [PATCH] wasm_c_api.c: improve unimplemented cases (#1355) ASSERT_NOT_IMPLEMENTED is bh_assert, which might be no-op. in that case, it's better to fall back to the "default" case, which reports an error properly. --- core/iwasm/common/wasm_c_api.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/core/iwasm/common/wasm_c_api.c b/core/iwasm/common/wasm_c_api.c index 4c1f6c544..52b6464ac 100644 --- a/core/iwasm/common/wasm_c_api.c +++ b/core/iwasm/common/wasm_c_api.c @@ -3955,9 +3955,8 @@ interp_link(const wasm_instance_t *inst, const WASMModule *module_interp, } case IMPORT_KIND_MEMORY: case IMPORT_KIND_TABLE: - ASSERT_NOT_IMPLEMENTED(); - break; default: + ASSERT_NOT_IMPLEMENTED(); LOG_WARNING("%s meets unsupported kind: %d", __FUNCTION__, import_rt->kind); goto failed; @@ -4175,9 +4174,8 @@ aot_link(const wasm_instance_t *inst, const AOTModule *module_aot, break; case WASM_EXTERN_MEMORY: case WASM_EXTERN_TABLE: - ASSERT_NOT_IMPLEMENTED(); - break; default: + ASSERT_NOT_IMPLEMENTED(); goto failed; } }