From 45db4ba2ee6b343f099eafaebe44a6cb5179e413 Mon Sep 17 00:00:00 2001
From: peter-tatrai <peter.tatrai.ext@siemens.com>
Date: Mon, 17 Feb 2025 06:34:40 +0100
Subject: [PATCH] fix(unit-test): libc_builtin_test issues (#4073)

- uninitialized buffer pointers (crashes)
- match integer constant size with printf specifier

Signed-off-by: Peter Tatrai <peter.tatrai.ext@siemens.com>
---
 tests/unit/libc-builtin/libc_builtin_test.cc | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/unit/libc-builtin/libc_builtin_test.cc b/tests/unit/libc-builtin/libc_builtin_test.cc
index 6598f7a8b..f4f02bff6 100644
--- a/tests/unit/libc-builtin/libc_builtin_test.cc
+++ b/tests/unit/libc-builtin/libc_builtin_test.cc
@@ -185,7 +185,7 @@ TEST_F(LibcBuiltinTest, printf)
         va_list.add(20);        //%zd
         va_list.add(20);        //%ld
 
-        va_list.add(20L);        //%jd
+        va_list.add(intmax_t(20));        //%jd
 
         testing::internal::CaptureStdout();
 
@@ -323,7 +323,7 @@ TEST_F(LibcBuiltinTest, printf)
 
 TEST_F(LibcBuiltinTest, sprintf)
 {
-    const char *buf;
+    char buf[200] = {0};
     const char *str = "Hello Wrold";
     const char *str_sig = "c";
     const char *str_f = "20, 3.140000, Hello World";
@@ -508,7 +508,7 @@ TEST_F(LibcBuiltinTest, memcmp)
 TEST_F(LibcBuiltinTest, memcpy)
 {
     const char *src = "Hell World";
-    char *dest;
+    char dest[sizeof(src)] = {0};
 
     AppData src_app{ dummy_exec_env.get(), src };
     AppData dest_app{ dummy_exec_env.get(), dest };
@@ -535,7 +535,7 @@ TEST_F(LibcBuiltinTest, memcpy)
 TEST_F(LibcBuiltinTest, memmove)
 {
     const char *src = "Hell World";
-    char *dest;
+    char dest[sizeof(src)] = {0};
 
     AppData src_app{ dummy_exec_env.get(), src };
     AppData dest_app{ dummy_exec_env.get(), dest };
@@ -673,7 +673,7 @@ TEST_F(LibcBuiltinTest, strncmp)
 TEST_F(LibcBuiltinTest, strcpy)
 {
     char *src = (char *)"Hello World!";
-    char *dest;
+    char dest[sizeof(src)] = {0};
 
     AppData src_app{ dummy_exec_env.get(), src };
     AppData dest_app{ dummy_exec_env.get(), dest };
@@ -696,7 +696,7 @@ TEST_F(LibcBuiltinTest, strcpy)
 TEST_F(LibcBuiltinTest, strncpy)
 {
     char *src = (char *)"Hello World!";
-    char *dest;
+    char dest[sizeof(src)] = {0};
 
     AppData src_app{ dummy_exec_env.get(), src };
     AppData dest_app{ dummy_exec_env.get(), dest };
@@ -1295,7 +1295,7 @@ TEST_F(LibcBuiltinTest, isalnum)
 TEST_F(LibcBuiltinTest, emscripten_memcpy_big)
 {
     const char *src = "Hell World";
-    char *dest;
+    char dest[sizeof(src)] = {0};
 
     AppData src_app{ dummy_exec_env.get(), src };
     AppData dest_app{ dummy_exec_env.get(), dest };