gnh1201/wasm-micro-runtime
1
0
Fork 0
mirror of https://github.com/bytecodealliance/wasm-micro-runtime.git synced 2025-05-12 20:51:21 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Remove unnecessary and extra zero length check in mem functions' macro (#2428)

Browse Source 
In macro bh_memcpy_s, bh_memcy_wa and bh_memmove_s, no need to do extra check
for length is zero or not because it was already done inside of the functions called.
This commit is contained in:
Cengizhan Pasaoglu 2023-08-08 03:52:25 +03:00 committed by GitHub
parent ebd9466d57
commit 81fbfbfcc0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/shared/utils/bh_common.c
View File

@ -31,6 +31,10 @@ b_memcpy_wa(void *s1, unsigned int s1max, const void *s2, unsigned int n)
unsigned int *p; unsigned int *p;
char *ps; char *ps;
if (n == 0) {
return 0;
}
if (pa > src) { if (pa > src) {
pa -= 4; pa -= 4;
} }

30
core/shared/utils/bh_common.h
View File

@ -12,25 +12,25 @@
extern "C" { extern "C" {
#endif #endif
#define bh_memcpy_s(dest, dlen, src, slen) \ #define bh_memcpy_s(dest, dlen, src, slen) \
do { \ do { \
int _ret = slen == 0 ? 0 : b_memcpy_s(dest, dlen, src, slen); \ int _ret = b_memcpy_s(dest, dlen, src, slen); \
(void)_ret; \ (void)_ret; \
bh_assert(_ret == 0); \ bh_assert(_ret == 0); \
} while (0) } while (0)
#define bh_memcpy_wa(dest, dlen, src, slen) \ #define bh_memcpy_wa(dest, dlen, src, slen) \
do { \ do { \
int _ret = slen == 0 ? 0 : b_memcpy_wa(dest, dlen, src, slen); \ int _ret = b_memcpy_wa(dest, dlen, src, slen); \
(void)_ret; \ (void)_ret; \
bh_assert(_ret == 0); \ bh_assert(_ret == 0); \
} while (0) } while (0)
#define bh_memmove_s(dest, dlen, src, slen) \ #define bh_memmove_s(dest, dlen, src, slen) \
do { \ do { \
int _ret = slen == 0 ? 0 : b_memmove_s(dest, dlen, src, slen); \ int _ret = b_memmove_s(dest, dlen, src, slen); \
(void)_ret; \ (void)_ret; \
bh_assert(_ret == 0); \ bh_assert(_ret == 0); \
} while (0) } while (0)
#define bh_strcat_s(dest, dlen, src) \ #define bh_strcat_s(dest, dlen, src) \