gnh1201/wasm-micro-runtime
1
0
Fork 0
mirror of https://github.com/bytecodealliance/wasm-micro-runtime.git synced 2025-06-18 02:59:21 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

aot_compile_op_call: Remove a wrong optimization (#2233)

Browse Source 
Unlike a tail-call, the caller of an ordinary recursive call doesn't
necessarily return immediately.
This commit is contained in:
YAMAMOTO Takashi 2023-05-25 08:44:54 +09:00 committed by GitHub
parent 7c766c2283
commit 94204b90ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/iwasm/compilation/aot_emit_function.c
View File

@ -868,10 +868,6 @@ aot_compile_op_call(AOTCompContext *comp_ctx, AOTFuncContext *func_ctx,
#if LLVM_VERSION_MAJOR >= 14 #if LLVM_VERSION_MAJOR >= 14
LLVMTypeRef llvm_func_type; LLVMTypeRef llvm_func_type;
#endif #endif
bool recursive_call =
(func_ctx == func_ctxes[func_idx - import_func_count]) ? true
: false;
if (comp_ctx->is_indirect_mode) { if (comp_ctx->is_indirect_mode) {
LLVMTypeRef func_ptr_type; LLVMTypeRef func_ptr_type;
@ -971,7 +967,7 @@ aot_compile_op_call(AOTCompContext *comp_ctx, AOTFuncContext *func_ctx,
/* Check whether there was exception thrown when executing /* Check whether there was exception thrown when executing
the function */ the function */
if (!tail_call && !recursive_call && comp_ctx->enable_bound_check if (!tail_call && comp_ctx->enable_bound_check
&& !check_exception_thrown(comp_ctx, func_ctx)) && !check_exception_thrown(comp_ctx, func_ctx))
goto fail; goto fail;
} }