From e9cc8731da157e03a2e07fc7aa9489e226210543 Mon Sep 17 00:00:00 2001 From: Benbuck Nason Date: Tue, 17 Sep 2024 19:24:30 -0700 Subject: [PATCH] Restore cmake hidden compile symbol visibility (#3796) This was originally fixed in #3655, but regressed in #3762 which removed the `-fvisibility=hidden` flag from the CMakeLists.txt file. This also removes extraneous ending whitespace from the file. --- CMakeLists.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 0531ec411..40658e9ac 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -124,7 +124,8 @@ include (${WAMR_ROOT_DIR}/build-scripts/runtime_lib.cmake) if (NOT WIN32) set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Wformat -Wformat-security \ -ffunction-sections -fdata-sections \ - -Wno-unused-parameter -Wno-pedantic") + -Wno-unused-parameter -Wno-pedantic \ + -fvisibility=hidden") # Remove the extra spaces for better make log string (REGEX REPLACE " *" " " CMAKE_C_FLAGS ${CMAKE_C_FLAGS}) set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wformat -Wformat-security -Wno-unused") @@ -168,7 +169,7 @@ if (WAMR_BUILD_STATIC) endif () if (WIN32) - target_link_libraries(iwasm_static PRIVATE ntdll) + target_link_libraries(iwasm_static PRIVATE ntdll) endif() install (TARGETS iwasm_static ARCHIVE DESTINATION lib) @@ -190,7 +191,7 @@ if (WAMR_BUILD_SHARED) endif () if (WIN32) - target_link_libraries(iwasm_shared PRIVATE ntdll) + target_link_libraries(iwasm_shared PRIVATE ntdll) endif() install (TARGETS iwasm_shared LIBRARY DESTINATION lib)