Merge pull request #3832 from loganek/loganek/simd

implement POP_V128()
2024-11-26 15:32:05 +00:00 · 2024-10-07 20:30:59 +02:00 · 2024-10-07 20:30:59 +02:00 · f7f1491f0d
commit f7f1491f0d
parent 326aea298c 860379bc58
2 changed files with 5 additions and 3 deletions
--- a/core/iwasm/common/wasm_loader_common.c
+++ b/core/iwasm/common/wasm_loader_common.c
@ -89,7 +89,8 @@ is_valid_value_type(uint8 type)
 bool
 is_valid_value_type_for_interpreter(uint8 value_type)
 {
-#if (WASM_ENABLE_WAMR_COMPILER == 0) && (WASM_ENABLE_JIT == 0)
+#if (WASM_ENABLE_WAMR_COMPILER == 0) && (WASM_ENABLE_JIT == 0) \
+    && (WASM_ENABLE_FAST_INTERP == 0)
    /*
     * Note: regardless of WASM_ENABLE_SIMD, our interpreters don't have
     * SIMD implemented. It's safer to reject v128, especially for the
--- a/core/iwasm/interpreter/wasm_interp_fast.c
+++ b/core/iwasm/interpreter/wasm_interp_fast.c
@ -485,6 +485,8 @@ wasm_interp_get_frame_ref(WASMInterpFrame *frame)

 #define POP_I64() (GET_I64_FROM_ADDR(frame_lp + GET_OFFSET()))

+#define POP_V128() (GET_V128_FROM_ADDR(frame_lp + GET_OFFSET()))
+
 #define POP_F64() (GET_F64_FROM_ADDR(frame_lp + GET_OFFSET()))

 #define POP_REF()                                                    \
@ -5662,8 +5664,7 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
                    }
                    case SIMD_v128_any_true:
                    {
-                        V128 value = GET_OPERAND_V128(0);
-                        frame_ip += 2;
+                        V128 value = POP_V128();
                        addr_ret = GET_OFFSET();
                        frame_lp[addr_ret] =
                            value.i64x2[0] != 0 || value.i64x2[1] != 0;